From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O4AIS-0004It-Dz
	for qemu-devel@nongnu.org; Tue, 20 Apr 2010 06:03:12 -0400
Received: from [140.186.70.92] (port=49343 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O4AIJ-0004BW-L7
	for qemu-devel@nongnu.org; Tue, 20 Apr 2010 06:03:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <quintela@redhat.com>) id 1O4AIH-0001Jf-HC
	for qemu-devel@nongnu.org; Tue, 20 Apr 2010 06:03:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56038)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <quintela@redhat.com>) id 1O4AIH-0001Is-9b
	for qemu-devel@nongnu.org; Tue, 20 Apr 2010 06:03:01 -0400
Received: from int-mx08.intmail.prod.int.phx2.redhat.com
	(int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3KA2vEl021538
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 20 Apr 2010 06:02:57 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1271683281-26825-1-git-send-email-kwolf@redhat.com> (Kevin
	Wolf's message of "Mon, 19 Apr 2010 15:21:21 +0200")
References: <1271683281-26825-1-git-send-email-kwolf@redhat.com>
Date: Tue, 20 Apr 2010 12:02:55 +0200
Message-ID: <m3pr1u786o.fsf@trasno.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: [Qemu-devel] Re: [PATCH v2] qcow2: Fix creation of large images
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org

Kevin Wolf <kwolf@redhat.com> wrote:
> qcow_create2 assumes that the new image will only need one cluster for its
> refcount table initially. Obviously that's not true any more when the image is
> big enough (exact value depends on the cluster size).
>
> This patch calculates the refcount table size dynamically.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> v2:
> - Made cluster calculation a bit more readable

Acked-by: Juan Quintela <quintela@redhat.com>

This version is much more readable.