From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nx1FH-0002t7-6F for qemu-devel@nongnu.org; Wed, 31 Mar 2010 12:58:23 -0400 Received: from [140.186.70.92] (port=42643 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nx1FD-0002rm-OK for qemu-devel@nongnu.org; Wed, 31 Mar 2010 12:58:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nx1FC-0006Wq-6l for qemu-devel@nongnu.org; Wed, 31 Mar 2010 12:58:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56457) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nx1FB-0006Wg-Ve for qemu-devel@nongnu.org; Wed, 31 Mar 2010 12:58:18 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2VGwGJ9031818 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 31 Mar 2010 12:58:17 -0400 From: Juan Quintela In-Reply-To: (Markus Armbruster's message of "Wed, 31 Mar 2010 17:31:49 +0200") References: <689f24e27d483de0e3201a9386c772dc241d4178.1270022701.git.shaharh@redhat.com> Date: Wed, 31 Mar 2010 18:58:14 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord' List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Shahar Havivi , qemu-devel@nongnu.org Markus Armbruster wrote: > Juan Quintela writes: >> I still think that adding an "id" property as in markus proposal would >> be neat. Otherwise I don't know how you are going to distinguish >> between two keyboards with the same name. > > If I understand the patch correctly (only time for a quick skim today), > the keyboard receives a numeric ID when it is created, and keyboard_set > identifies it by that ID. Yes, a user-defined ID would be nicer, and > consistent with how similar things work. But the numeric ID isn't > *wrong*, as far as I can see. my problem is that if you add two keyboards of the same type, they will receive random index (different ones), now you do info keyboard, and you see two keyboard with the same names and different numbers, how do you know which of the two given you want to choose? And no, I don't have magic bullet to make multimonitor/keyboard/mouse behave as expected out of given them right id's. Later, Juan.