From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NXe9Y-00023y-I0
	for qemu-devel@nongnu.org; Wed, 20 Jan 2010 12:15:36 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NXe9U-00021l-RS
	for qemu-devel@nongnu.org; Wed, 20 Jan 2010 12:15:36 -0500
Received: from [199.232.76.173] (port=32790 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NXe9U-00021a-Jh
	for qemu-devel@nongnu.org; Wed, 20 Jan 2010 12:15:32 -0500
Received: from mx1.redhat.com ([209.132.183.28]:12315)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <armbru@redhat.com>) id 1NXe9U-0000Pv-AF
	for qemu-devel@nongnu.org; Wed, 20 Jan 2010 12:15:32 -0500
From: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/8] monitor: Document argument type 'M'
References: <1264003702-17329-1-git-send-email-armbru@redhat.com>
	<1264003702-17329-2-git-send-email-armbru@redhat.com>
	<58BD0469C48A7443A479A13D101685E303BDD099@ala-mail09.corp.ad.wrs.com>
Date: Wed, 20 Jan 2010 18:15:28 +0100
In-Reply-To: <58BD0469C48A7443A479A13D101685E303BDD099@ala-mail09.corp.ad.wrs.com>
	(Chris Krumme's message of "Wed, 20 Jan 2010 08:41:05 -0800")
Message-ID: <m3pr54ofyn.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Krumme, Chris" <Chris.Krumme@windriver.com>
Cc: qemu-devel@nongnu.org

"Krumme, Chris" <Chris.Krumme@windriver.com> writes:

> Hello Markus,
>
> Not sure of the best answer, but thought there should be some
> discussion.
>
> You mention Mebibyte, which according to the all knowing Wikipedia, is
> abbreviated Mi.
>
> I understand that if you will only support one, then maybe you don't
> need to differentiate from Megabyte, but then in a later patch you use
> m, u, and n for powers of 10. This causes your new double format to use
> powers of 2 above one and powers of 10 below.

Really?

Argument types M and b use powers of 2.

Argument type T uses powers of 10.

> Maybe this is just one of those geek things, powers of 2 for integers,
> and powers of 10 for fractions.
>
> Good luck.

I merely reimplemented existing usage in a way that does the right thing
for QMP.  Can't say I like the ad-hocery there, but improving the
(non-QMP) monitor is not my objective right now.