From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NVqxl-00073D-5n
	for qemu-devel@nongnu.org; Fri, 15 Jan 2010 13:32:01 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NVqxf-0006wc-9d
	for qemu-devel@nongnu.org; Fri, 15 Jan 2010 13:31:59 -0500
Received: from [199.232.76.173] (port=57453 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NVqxf-0006wK-0x
	for qemu-devel@nongnu.org; Fri, 15 Jan 2010 13:31:55 -0500
Received: from mx20.gnu.org ([199.232.41.8]:33758)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <armbru@redhat.com>) id 1NVqxd-0003tq-Uo
	for qemu-devel@nongnu.org; Fri, 15 Jan 2010 13:31:54 -0500
Received: from mx1.redhat.com ([209.132.183.28])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <armbru@redhat.com>) id 1NVqxH-0002wN-3A
	for qemu-devel@nongnu.org; Fri, 15 Jan 2010 13:31:31 -0500
From: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [RFC,PATCH 00/11] Half-convert info qtree to QMP.
References: <1261861899-1984-1-git-send-email-nathan@parenthephobia.org.uk>
Date: Fri, 15 Jan 2010 19:31:24 +0100
In-Reply-To: <1261861899-1984-1-git-send-email-nathan@parenthephobia.org.uk>
	(Nathan Baum's message of "Sat, 26 Dec 2009 21:11:28 +0000")
Message-ID: <m3pr5bdxtv.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Nathan Baum <nathan@parenthephobia.org.uk>
Cc: qemu-devel@nongnu.org

Nathan Baum <nathan@parenthephobia.org.uk> writes:

> Hullo.
>
> This series of patches partially converts info qtree to QMP.
>
> I've gone halfway: one can use query-qtree in QMP.
>
> I haven't converted the old monitor function other than to rename it;
> do_info_qtree_print just ignores the QObject it is passed and prints
> the qtree the old-fashioned way.
>
>  hw/isa-bus.c |   19 +++++++++++++
>  hw/pci.c     |   50 +++++++++++++++++++++++++++++++++++
>  hw/qdev.c    |   82 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>  hw/qdev.h    |    5 +++-
>  hw/sysbus.c  |   20 ++++++++++++++
>  hw/usb-bus.c |   15 ++++++++++
>  monitor.c    |    3 +-
>  7 files changed, 191 insertions(+), 3 deletions(-)

Patch 2 adds a static function, patch 3 puts it to use.  Not bisectable
with -Werror.  Merge the two.  Same for patch 4+5, 6+7, 8+9, 10+11.

Completing the job shouldn't be hard, just change the print_dev methods
to format the value returned by the info_dev method instead of getting
the information out of the device.

Thanks!