Re: [Qemu-devel] [PATCH] isa: configure serial+parallel by index.

[Markus Armbruster <armbru@redhat.com>]

Markus Armbruster <armbru@redhat.com> writes:

> Gerd Hoffmann <kraxel@redhat.com> writes:
>
>> This patch adds a 'index' property to the isa-parallel and isa-serial
>> devices.  This can be used to create devices with the default isa irqs
>> and ioports by simply specifying the index, i.e.
>>
>>    -device isa-serial,index=1
>>
>> instead of
>>
>>    -device isa-serial,iobase=0x2f8,irq=3
>>
>> for ttyS1 aka com2.  Likewise for parallel ports.
>
> Not mentioned here, only in the code:
>
> * index defaults to 0 for the first device to initialize, 1 for the
>   second, and so forth.
>
> * It is okay to overwrite the defaults provided by index, e.g.
>
>     -device isa-serial,index=1,irq=4
>
> Looks fine to me.  A similar solution could do for default mac address.

One little thing I missed on first reading: making an index property
hexadecimal is weird.  I'd really expect decimal there.