All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Chouquet-Stringer <mchouque@e-steel.com>
To: linux-kernel@vger.kernel.org
Subject: Re: Floppy disk strange behavior
Date: 09 Jan 2001 17:44:58 -0500	[thread overview]
Message-ID: <m3puhwtket.fsf@shookay.e-steel.com> (raw)
In-Reply-To: <E14G6S5-0007UK-00@the-village.bc.nu> <Pine.GSO.4.21.0101091642260.9953-100000@weyl.math.psu.edu>


Ok, I emailed bug-fileutils@gnu.org and got this response from Jim Meyering
<jim@meyering.net>:

Thanks for the report.
That's fixed in the latest test release.
  ftp://alpha.gnu.org/gnu/fetish/fileutils-4.0.35.tar.gz

It's fixed in 4.0.33, too.

viro@math.psu.edu (Alexander Viro) writes:
> On Tue, 9 Jan 2001, Alan Cox wrote:
> 
> > > dd bug. It tries to ftruncate() the output file and gets all upset when
> > > kernel refuses to truncate a block device (surprise, surprise).
> > 
> > Standards compliant but unexpected. 
> 
> dd is supposed to be portable. On Solaris:
> % man ftruncate
> [snip]
>       EINVAL    The fildes argument  does  not  correspond  to  an
>                ordinary file.
>  
> > Actually its explicitly mentioned by the spec that truncate _may_ extend
> > a file but need not do so. 
> 
> However, it also explicitly mentions that truncate can fail for non-regular
> file.
> 
> > > Try to build GNU dd on other Unices and you will be able to trigger that
> > > bug on quite a few of them.
> > 
> > I think not
> 
> Solaris, for one thing. OK, let's ask folks to test it on different systems
> and see what it gives.
> 
> > > ftruncate(2) is _not_ supposed to succeed on anything other than regular
> > > files. I.e. dd(1) should not call it and expect success if file is not
> > > regular. Plain and simple...
> > 
> > 2.2 is least suprise 2.4 is most information, but misleading errno IMHO
> 
> Agreed. It should be -EINVAL, not -EPERM.
> 
> IMO there are two issues:
> 	* dd(1) portability bug. Obviously there - ftruncate(2) is allowed
> to fail on non-regular ones. Fix is trivial and it (or something equivalent)
> should go into the fileutils.
> 	* What should 2.4 do here? I would prefer -EINVAL - it is true
> (requested action is invalid for the arguments we got), it is consistent
> with other systems and it doesn't hide the failure. Data that used to
> be in the file we were trying to truncate is still there. -EPERM is
> arguably wrong here - it's not like the problem was in the lack of
> permissions.
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> Please read the FAQ at http://www.tux.org/lkml/
> 

-- 
Mathieu CHOUQUET-STRINGER              E-Mail : mchouque@e-steel.com
     Learning French is trivial: the word for horse is cheval, and
               everything else follows in the same way.
                        -- Alan J. Perlis
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

  reply	other threads:[~2001-01-09 22:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-01-09 20:33 Floppy disk strange behavior Mathieu Chouquet-Stringer
2001-01-09 21:22 ` Alexander Viro
2001-01-09 21:37   ` Alan Cox
2001-01-09 21:57     ` Alexander Viro
2001-01-09 22:44       ` Mathieu Chouquet-Stringer [this message]
2001-01-09 23:20       ` Alan Cox
  -- strict thread matches above, loose matches on Subject: below --
2001-01-09 23:03 Andries.Brouwer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3puhwtket.fsf@shookay.e-steel.com \
    --to=mchouque@e-steel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.