From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Schwab Date: Tue, 01 Jun 2010 08:36:21 +0000 Subject: Re: [PATCH] KVM: PPC: elide struct thread_struct instances from stack Message-Id: List-Id: References: <20100531224040.GA22927@brick.ozlabs.ibm.com> In-Reply-To: <20100531224040.GA22927-oklZEfemRj05kJ7NmlRacFaTQe2KTcn/@public.gmane.org> (Paul Mackerras's message of "Tue, 1 Jun 2010 08:40:40 +1000") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Paul Mackerras Cc: kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, Alexander Graf , kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Paul Mackerras writes: > I re-read the relevant part of the PowerPC architecture spec > yesterday, and it seems pretty clear that the FPSCR doesn't affect the > behaviour of lfs and stfs, and is not affected by them. So in fact 4 > out of the 7 instructions in each of those procedures are unnecessary > (and similarly for the cvt_fd/df used in the alignment fixup code). I'd prefer to have this deferred to a separate patch. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by ozlabs.org (Postfix) with ESMTP id C4E50B7D2D for ; Tue, 1 Jun 2010 18:36:25 +1000 (EST) From: Andreas Schwab To: Paul Mackerras Subject: Re: [PATCH] KVM: PPC: elide struct thread_struct instances from stack References: <20100531224040.GA22927@brick.ozlabs.ibm.com> Date: Tue, 01 Jun 2010 10:36:21 +0200 In-Reply-To: <20100531224040.GA22927@brick.ozlabs.ibm.com> (Paul Mackerras's message of "Tue, 1 Jun 2010 08:40:40 +1000") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linuxppc-dev@ozlabs.org, Alexander Graf , kvm-ppc@vger.kernel.org, kvm@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Paul Mackerras writes: > I re-read the relevant part of the PowerPC architecture spec > yesterday, and it seems pretty clear that the FPSCR doesn't affect the > behaviour of lfs and stfs, and is not affected by them. So in fact 4 > out of the 7 instructions in each of those procedures are unnecessary > (and similarly for the cvt_fd/df used in the alignment fixup code). I'd prefer to have this deferred to a separate patch. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Schwab Subject: Re: [PATCH] KVM: PPC: elide struct thread_struct instances from stack Date: Tue, 01 Jun 2010 10:36:21 +0200 Message-ID: References: <20100531224040.GA22927@brick.ozlabs.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, Alexander Graf , kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Paul Mackerras Return-path: In-Reply-To: <20100531224040.GA22927-oklZEfemRj05kJ7NmlRacFaTQe2KTcn/@public.gmane.org> (Paul Mackerras's message of "Tue, 1 Jun 2010 08:40:40 +1000") Sender: kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: kvm.vger.kernel.org Paul Mackerras writes: > I re-read the relevant part of the PowerPC architecture spec > yesterday, and it seems pretty clear that the FPSCR doesn't affect the > behaviour of lfs and stfs, and is not affected by them. So in fact 4 > out of the 7 instructions in each of those procedures are unnecessary > (and similarly for the cvt_fd/df used in the alignment fixup code). I'd prefer to have this deferred to a separate patch. Andreas. -- Andreas Schwab, schwab-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."