From: Jakub Narebski <jnareb@gmail.com>
To: "Zoltán Füzesi" <zfuzesi@eaglet.hu>
Cc: git@vger.kernel.org, Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Subject: Re: [PATCH/RFC] gitweb: parse_commit_text encoding fix
Date: Sat, 01 Aug 2009 02:21:55 -0700 (PDT) [thread overview]
Message-ID: <m3r5vvris1.fsf@localhost.localdomain> (raw)
In-Reply-To: <1249115323-17974-1-git-send-email-zfuzesi@eaglet.hu>
Zoltán Füzesi <zfuzesi@eaglet.hu> writes:
> Call to_utf8 when parsing author and committer names, otherwise they
> will appear with bad encoding if they written by using
> chop_and_escape_str.
[re-wrapped]
>
> Signed-off-by: Zoltán Füzesi <zfuzesi@eaglet.hu>
Thanks.
Still, I do wonder if it would be possible to simply do the following:
-binmode STDOUT, ':utf8';
+use open qw(:std :utf8);
...but it unfortunately doesn't work. It was tried in
http://thread.gmane.org/gmane.comp.version-control.git/87129/focus=87135
to_utf8() has at least (possible) fallback if it encounters characters
outside of UTF-8 coding.
> - $co{'author'} = $1;
> + $co{'author'} = to_utf8($1);
--
Jakub Narebski
Git User's Survey 2009:
http://tinyurl.com/GitSurvey2009
next prev parent reply other threads:[~2009-08-01 9:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-01 8:28 [PATCH/RFC] gitweb: parse_commit_text encoding fix Zoltán Füzesi
2009-08-01 9:21 ` Jakub Narebski [this message]
2009-08-01 16:55 ` Füzesi Zoltán
2009-08-02 7:42 ` [PATCH] " Zoltán Füzesi
2009-08-04 6:59 ` Junio C Hamano
2009-08-06 8:15 ` Zoltán Füzesi
2009-08-07 20:31 ` Jakub Narebski
2009-08-07 0:41 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3r5vvris1.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=giuseppe.bilotta@gmail.com \
--cc=zfuzesi@eaglet.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.