All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: Jonas Fonseca <fonseca@diku.dk>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [ANNOUNCE] tig-0.14
Date: Fri, 06 Feb 2009 14:53:02 -0800 (PST)	[thread overview]
Message-ID: <m3r62buqiv.fsf@localhost.localdomain> (raw)
In-Reply-To: <2c6b72b30902061410l64c98c33g19b97f656d347c83@mail.gmail.com>

Jonas Fonseca <fonseca@diku.dk> writes:

> On Fri, Feb 6, 2009 at 20:15, Jeff King <peff@peff.net> wrote:
> > On Thu, Feb 05, 2009 at 09:44:36PM +0100, Jonas Fonseca wrote:
>>
>>>  - Blame view: load blame for parent commit. For merge commits the parent
>>>    is queried. Bound to ',' by default via the existing "parent" action.

>> It looks like you just keep the view on the same line number when moving
>> to the new blame output. In practice, this has very mixed results. Most
>> of the time it does exactly what I want, but if the file changes
>> significantly, you get dumped at a totally unrelated part of the file.
>> I'm not sure if there is a more clever solution, though.
> 
> Yes, it is a bit easy to get lost. It should be possible to find the
> original line number either by making git-blame also honor
> --show-number for the --incremental output or by using the "porcelain"
> version:
> 
>   git blame --show-number -L <line>,<line> <rev> <file>

Errr... you are wrong.  There are three line numbers when browsing
blame output.  Original line number, line number in _blamed_ commit
(shown with --show-number, --porcelain, --incremental), and line
number in _parent_ of blamed commit... which we don't know, and
which I don't think it is easy to find...

-- 
Jakub Narebski
Poland
ShadeHawk on #git

  reply	other threads:[~2009-02-06 22:54 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-05 20:44 [ANNOUNCE] tig-0.14 Jonas Fonseca
2009-02-06 10:49 ` bill lam
2009-02-06 14:29   ` Jonas Fonseca
2009-02-06 15:25     ` Sitaram Chamarty
2009-02-08 10:07       ` Jonas Fonseca
2009-02-11 16:05         ` showing SHA1 of parent commit in tig [was " Sitaram Chamarty
2009-02-12  1:19           ` Jonas Fonseca
2009-02-12  3:28             ` Sitaram Chamarty
2009-02-06 19:15 ` Jeff King
2009-02-06 22:10   ` Jonas Fonseca
2009-02-06 22:53     ` Jakub Narebski [this message]
2009-02-08 10:13       ` Jonas Fonseca
2009-02-07  7:10     ` Jeff King
2009-02-07  7:28       ` Junio C Hamano
2009-02-07  8:55         ` david
2009-02-08 10:47           ` Jonas Fonseca
2009-02-08 10:55             ` Jonas Fonseca
2009-02-08 11:06               ` Jeff King
2009-02-08 11:52                 ` Jonas Fonseca
2009-02-07 11:26         ` Jeff King
2009-02-08 10:31       ` Jonas Fonseca
2009-02-08 11:00         ` Jeff King
2009-02-08 11:49           ` Jonas Fonseca
2009-02-07  2:48 ` Mikael Magnusson
2009-02-09 22:07 ` Peter Baumann
2009-02-09 22:22   ` Jeff King
2009-02-09 22:30     ` Peter Baumann
2009-02-10 18:42       ` Jonas Fonseca
2009-02-10 21:23         ` Jari Aalto
2009-02-10 13:29 ` Ted Pavlic
2009-02-10 18:29   ` Jonas Fonseca
2009-02-10 19:07     ` Brian Gernhardt
2009-02-10 19:29       ` Stefan Karpinski
2009-02-10 20:41         ` Jonas Fonseca
2009-02-10 20:49           ` Brian Gernhardt
2009-02-10 21:13             ` Jonas Fonseca
2009-02-10 21:18               ` Brian Gernhardt
2009-02-11 14:06             ` Ted Pavlic
2009-02-12  1:30               ` Jonas Fonseca
2009-02-11 14:19           ` Ted Pavlic
2009-02-20 17:24           ` Ted Pavlic
2009-02-20 18:34             ` Jonas Fonseca
2009-02-20 20:36               ` Ted Pavlic
2009-02-20 23:31                 ` Jonas Fonseca
2009-02-25 21:54                 ` Jonas Fonseca
2009-02-11 14:03     ` Ted Pavlic
2009-02-11 14:12       ` Ted Pavlic
2009-02-11 17:47 ` Ted Pavlic
2009-02-12  1:08   ` Jonas Fonseca
2009-02-12 21:48 ` Tilo Schwarz
2009-02-12 22:24   ` Jonas Fonseca
2009-02-12 23:14     ` Tilo Schwarz
2009-02-15 23:47       ` Jonas Fonseca
2009-02-16  1:33         ` Sitaram Chamarty
2009-02-16 12:10           ` Jonas Fonseca
2009-02-16 15:14             ` Sitaram Chamarty
2009-02-16 15:25               ` Thomas Adam
2009-02-16 19:52                 ` Jonas Fonseca
2009-02-17  7:47                   ` Marco Costalba
2009-02-16 21:12         ` Tilo Schwarz
2009-02-20 23:35           ` Jonas Fonseca
2009-02-21 17:35             ` Tilo Schwarz
2009-02-21 17:41               ` Jonas Fonseca
2009-02-21 20:18                 ` Tilo Schwarz
2009-02-16 21:55         ` Tilo Schwarz
2009-02-13  2:31     ` bill lam
2009-02-13 23:57       ` Jonas Fonseca
2009-02-14  3:31         ` bill lam
2009-02-15 23:22           ` Jonas Fonseca

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3r62buqiv.fsf@localhost.localdomain \
    --to=jnareb@gmail.com \
    --cc=fonseca@diku.dk \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.