From: Jakub Narebski <jnareb@gmail.com>
To: "Flavio Poletti (polettix)" <flavio@polettix.it>
Cc: git@vger.kernel.org, normalperson@yhbt.net
Subject: Re: [PATCH] Enhanced auto-discovery of httpd location and call conventions.
Date: Thu, 12 Jun 2008 00:52:36 -0700 (PDT) [thread overview]
Message-ID: <m3r6b3qedj.fsf@localhost.localdomain> (raw)
In-Reply-To: <1213235480-21925-1-git-send-email-flavio@polettix.it>
"Flavio Poletti (polettix)" <flavio@polettix.it> writes:
> Another minor change is a substitution of a shell sub-call using "$()"
> by means of backticks. In my understanding, plain /bin/sh does not support
> "$()".
But POSIX shell does. And git does make use of it rather extensively.
Besides, see Documentation/CodingGuidelines:
For shell scripts specifically (not exhaustive):
- We prefer $( ... ) for command substitution; unlike ``, it
properly nests. It should have been the way Bourne spelled
it from day one, but unfortunately isn't.
--
Jakub Narebski
Poland
ShadeHawk on #git
next prev parent reply other threads:[~2008-06-12 7:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-12 1:51 [PATCH] Enhanced auto-discovery of httpd location and call conventions Flavio Poletti (polettix)
2008-06-12 7:52 ` Jakub Narebski [this message]
2008-06-12 9:59 ` [PATCH v2] git-instaweb: Enhanced auto-discovery of httpd and call conventions. Removed backticks Flavio Poletti
2008-06-12 21:54 ` [PATCH v3] " Flavio Poletti
2008-06-13 17:02 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3r6b3qedj.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=flavio@polettix.it \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.