From: Jes Sorensen <jes@trained-monkey.org>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: acenic >4gig sendfile problem
Date: 24 Jun 2002 11:31:15 -0400 [thread overview]
Message-ID: <m3r8iwvgl8.fsf@trained-monkey.org> (raw)
In-Reply-To: Dave Hansen's message of "Mon, 10 Jun 2002 14:55:23 -0700"
>>>>> "Dave" == Dave Hansen <haveblue@us.ibm.com> writes:
Dave> When doing sendfile with my acenic card on my 8xPIII-700 and PAE
Dave> running 2.4.18, I'm getting all zeros in the files being
Dave> transmitted. Running the Redhat 2.4.18-4 kernel fixes the
Dave> problem. I saw this entry in the rpm's changelog: * Sat Aug 25
Dave> 2001 Ingo Molnar <mingo@redhat.com> - fix the acenic driver bug
Dave> that caused random kernel memory being sent out on the wire, on
Dave> x86 systems with more than 4 GB RAM.
Actually I think you're hitting a bug in pci_map_page() rather than in
the acenic.driver.
Try the patch from Ben LaHaise included below.
Jes
------- Start of forwarded message -------
Resent-Message-Id: <200206102358.g5ANwbx23959@toomuch.toronto.redhat.com>
Date: Mon, 10 Jun 2002 19:56:44 -0400
From: Benjamin LaHaise <bcrl@redhat.com>
To: Marcelo Tosatti <marcelo@conectiva.com.br>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: highmem pci dma mapping does not work, missing cast in asm-i386/pci.h
Message-ID: <20020610195644.C13225@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Resent-From: bcrl@redhat.com
Resent-Date: Mon, 10 Jun 2002 19:58:37 -0400
Resent-To: jes@wildopensource.com
Hello all,
There's a missing cast in pci_map_page that causes 64 bit capable
drivers to access the wrong memory for highmem pages. Please
include the patch below to fix it.
-ben
--
"You will be reincarnated as a toad; and you will be much happier."
:r ~/patches/v2.4/v2.4.19-pre10-pci_highmem.diff
diff -urN v2.4.19-pre10/include/asm-i386/pci.h pci-v2.4.19-pre10/include/asm-i386/pci.h
--- v2.4.19-pre10/include/asm-i386/pci.h Thu Jun 6 20:10:08 2002
+++ pci-v2.4.19-pre10/include/asm-i386/pci.h Mon Jun 10 19:54:16 2002
@@ -103,7 +103,7 @@
if (direction == PCI_DMA_NONE)
out_of_line_bug();
- return (page - mem_map) * PAGE_SIZE + offset;
+ return (dma_addr_t)(page - mem_map) * PAGE_SIZE + offset;
}
static inline void pci_unmap_page(struct pci_dev *hwdev, dma_addr_t dma_address,
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
------- End of forwarded message -------
next prev parent reply other threads:[~2002-06-24 15:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-10 21:55 acenic >4gig sendfile problem Dave Hansen
2002-06-24 15:31 ` Jes Sorensen [this message]
2002-06-24 15:54 ` Roy Sigurd Karlsbakk
2002-06-24 16:02 ` David S. Miller
2002-06-25 6:46 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3r8iwvgl8.fsf@trained-monkey.org \
--to=jes@trained-monkey.org \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.