From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:52435) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qlhm0-0006jZ-17 for qemu-devel@nongnu.org; Tue, 26 Jul 2011 09:34:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qlhlt-00018t-0B for qemu-devel@nongnu.org; Tue, 26 Jul 2011 09:34:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7059) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qlhls-00018P-MM for qemu-devel@nongnu.org; Tue, 26 Jul 2011 09:34:04 -0400 From: Markus Armbruster References: <1311179069-27882-1-git-send-email-armbru@redhat.com> <1311179069-27882-13-git-send-email-armbru@redhat.com> <20110726115756.GA1418@lst.de> Date: Tue, 26 Jul 2011 15:33:54 +0200 In-Reply-To: <20110726115756.GA1418@lst.de> (Christoph Hellwig's message of "Tue, 26 Jul 2011 13:57:56 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 12/55] ide: Fix ATA command READ to set ATAPI signature for CD-ROM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: kwolf@redhat.com, stefano.stabellini@eu.citrix.com, dbaryshkov@gmail.com, quintela@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, amit.shah@redhat.com Christoph Hellwig writes: > On Wed, Jul 20, 2011 at 06:23:46PM +0200, Markus Armbruster wrote: >> Must set the ATAPI device signature, see ACS-2 7.36.6 Outputs for >> PACKET feature set devices. > > Odd but true, even if it's 7.38.2 in my local copy of the ACS spec. > > It defintively should be documented in a comment next to the code, > given how odd the behaviour is. I can stick in a suitable comment when I respin.