From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=35374 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q0bfx-0000sM-6t
	for qemu-devel@nongnu.org; Fri, 18 Mar 2011 11:33:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1Q0bfv-0003xI-SX
	for qemu-devel@nongnu.org; Fri, 18 Mar 2011 11:33:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:17785)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1Q0bfv-0003wz-Jw
	for qemu-devel@nongnu.org; Fri, 18 Mar 2011 11:33:15 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <0a5deb668716e000b11c12b4b2668f86cbc604da.1300402145.git.yamahata@valinux.co.jp>
	(Isaku Yamahata's message of "Fri, 18 Mar 2011 07:51:33 +0900")
References: <cover.1300402145.git.yamahata@valinux.co.jp>
	<cover.1300402145.git.yamahata@valinux.co.jp>
	<0a5deb668716e000b11c12b4b2668f86cbc604da.1300402145.git.yamahata@valinux.co.jp>
Date: Fri, 18 Mar 2011 16:31:34 +0100
Message-ID: <m3sjuk5tt5.fsf@trasno.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: [Qemu-devel] Re: [PATCH v2 2/3] piix_pci: eliminate
	PIIX3State::pci_irq_levels
Reply-To: quintela@redhat.com
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org, mst@redhat.com

Isaku Yamahata <yamahata@valinux.co.jp> wrote:
> PIIX3State::pci_irq_levels are redundant which is already tracked by
> PCIBus layer. So eliminate them.

1st of all: Hurray to remove the entable between PIIX3State & i440fx.

> Cc: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
> ---
>  hw/piix_pci.c |   31 +++++++++++++++++++++----------
>  1 files changed, 21 insertions(+), 10 deletions(-)
>
> diff --git a/hw/piix_pci.c b/hw/piix_pci.c
> index 358da58..a1d1f55 100644
> --- a/hw/piix_pci.c
> +++ b/hw/piix_pci.c
> @@ -39,7 +39,7 @@ typedef PCIHostState I440FXState;
>  
>  typedef struct PIIX3State {
>      PCIDevice dev;
> -    int pci_irq_levels[4];
> +    int32_t dummy_for_save_load_compat[4];

Rest of devices normally call it:

    int32_t pci_irq_levels_vmstate[4];

Putting it as the last member of the struct helps (sometimes) with cache
performance issues.


Rest look nice.  Thanks.