From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=36787 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OvtML-0005wp-Ad
	for qemu-devel@nongnu.org; Wed, 15 Sep 2010 10:53:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <quintela@redhat.com>) id 1OvtMK-0000KS-6s
	for qemu-devel@nongnu.org; Wed, 15 Sep 2010 10:53:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:43152)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <quintela@redhat.com>) id 1OvtMK-0000K8-0P
	for qemu-devel@nongnu.org; Wed, 15 Sep 2010 10:53:16 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1284553440-17985-3-git-send-email-Jes.Sorensen@redhat.com> (Jes
	Sorensen's message of "Wed, 15 Sep 2010 14:23:57 +0200")
References: <1284553440-17985-1-git-send-email-Jes.Sorensen@redhat.com>
	<1284553440-17985-3-git-send-email-Jes.Sorensen@redhat.com>
Date: Wed, 15 Sep 2010 16:50:40 +0200
Message-ID: <m3sk1bdprz.fsf@trasno.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: [Qemu-devel] Re: [PATCH 2/5] Support human unit formats in
	strtobytes, eg. 1.0G
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes.Sorensen@redhat.com
Cc: qemu-devel@nongnu.org, armbru@redhat.com

Jes.Sorensen@redhat.com wrote:
> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>          value <<= 10;
>          break;
>      case 0:
> +        if (divider) {
> +            value = 0;
> +            break;

changing break by goto fail here?
1.5G and 1.0G is ok, but using 1024.00  or similar should be one error,
no?

nice cleanup for the rest of the patch series.

Later, Juan.


> +        }
>      case 'M':
>      case 'm':
>          value <<= 20;