All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: Greg Brockman <gdb@MIT.EDU>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Johannes Sixt" <j.sixt@viscovery.net>,
	"Junio Hamano" <gitster@pobox.com>,
	"Jonathan Nieder" <jrnieder@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCHv3] Updated patch series for providing mechanism to list  available repositories
Date: Tue, 27 Jul 2010 02:02:38 -0700 (PDT)	[thread overview]
Message-ID: <m3sk35l2n6.fsf@localhost.localdomain> (raw)
In-Reply-To: <AANLkTikG0e5dtGgMe03s=PpG793B-MkrGjdGa0LuZ5zH@mail.gmail.com>

Greg Brockman <gdb@MIT.EDU> writes:

> > It would probably help if you re-send the entire thing again.
>
> Ok, will do so shortly.
> 
> > It also seems to have an unaddressed comment
> > (<7vlj96m4mc.fsf@alter.siamese.dyndns.org> from Junio).
>
> Yep, my patch series actually does incorporate that comment.  I didn't
> respond to that explicitly because I didn't want to spam the list, but
> in the future I'll be sure to respond to comments... I can imagine it
> makes things much easier for
> people-who-are-not-the-one-writing-the-patch to follow.

There are two possible solutions to providing comments about patch (I
think they are covered in Documentation/SubmittingPatches).

First is reply to email like you would usually do, and below some
delimiter, e.g. the "scissors" line i.e. '-- >8 --' put the patch
itself.  You might need to start it with 'Subject:' line if the title
of the patch is different from the subject of email.

Second, which I think would be more appropriate in your situation, is
to put comments about patch, for example how you did address the
comments, and/or how the patch changed from previous version in the
area between '---' delimiter line, and diffstat.  See for example
http://permalink.gmane.org/gmane.comp.version-control.git/151703

HTH
-- 
Jakub Narebski
Poland
ShadeHawk on #git

  reply	other threads:[~2010-07-27  9:02 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-21 15:15 [PATCHv3] Updated patch series for providing mechanism to list available repositories Greg Brockman
2010-07-21 15:15 ` [PATCH 1/3] Allow creation of arbitrary git-shell commands Greg Brockman
2010-07-21 15:15 ` [PATCH 2/3] Add interactive mode to git-shell for user-friendliness Greg Brockman
2010-07-21 15:15 ` [PATCH 3/3] Add sample commands for git-shell Greg Brockman
2010-07-26 22:32 ` [PATCHv3] Updated patch series for providing mechanism to list available repositories Greg Brockman
2010-07-26 22:54   ` Ævar Arnfjörð Bjarmason
2010-07-26 23:18     ` Greg Brockman
2010-07-27  9:02       ` Jakub Narebski [this message]
2010-07-26 23:28     ` Jonathan Nieder
2010-07-27  0:20       ` Greg Brockman
2010-07-27  0:50         ` Jonathan Nieder
2010-07-27  7:16         ` Johannes Sixt
2010-07-27 17:41           ` Jonathan Nieder
2010-07-27 22:43             ` Greg Brockman
2010-07-28  0:33               ` Jonathan Nieder
2010-07-28  6:15                 ` Greg Brockman
2010-07-28  6:42                   ` Jonathan Nieder
2010-07-28  7:06                     ` Greg Brockman
2010-07-28 23:14                     ` Anders Kaseorg
2010-07-28 23:52                       ` Jonathan Nieder
2010-07-29  0:21                         ` Greg Brockman
2010-07-29  0:33                           ` Jonathan Nieder
2010-07-28  1:10               ` Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3sk35l2n6.fsf@localhost.localdomain \
    --to=jnareb@gmail.com \
    --cc=avarab@gmail.com \
    --cc=gdb@MIT.EDU \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j.sixt@viscovery.net \
    --cc=jrnieder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.