All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: Pierre Habouzit <madcoder@debian.org>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 1/2] Introduce leaky().
Date: Tue, 24 Jun 2008 14:28:30 -0700 (PDT)	[thread overview]
Message-ID: <m3skv2jzey.fsf@localhost.localdomain> (raw)
In-Reply-To: <1214338474-16822-2-git-send-email-madcoder@debian.org>

Pierre Habouzit <madcoder@debian.org> writes:

> diff --git a/Makefile b/Makefile

> +#
> +# Define COLLECT_LEAKS_AT_EXIT if you want memory marked as leaky() at exit.

I think s/at exit/to be freed &/;


> diff --git a/cache.h b/cache.h

Hmmm... cache?

>  /* alloc.c */
> +#ifdef COLLECT_LEAKS_AT_EXIT
> +extern void *leaky(void *);
> +#else
> +# define leaky(x) x
> +#endif

Not 

+# define leaky(x) (x)

to be careful?
-- 
Jakub Narebski
Poland
ShadeHawk on #git

  parent reply	other threads:[~2008-06-24 21:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-24 20:14 [RFC] leaky() Pierre Habouzit
2008-06-24 20:14 ` [PATCH 1/2] Introduce leaky() Pierre Habouzit
2008-06-24 20:14   ` [PATCH 2/2] git-rev-parse: use leaky() Pierre Habouzit
2008-06-24 20:16   ` [PATCH 1/2] Introduce leaky() Pierre Habouzit
2008-06-24 21:28   ` Jakub Narebski [this message]
2008-06-24 22:10     ` Pierre Habouzit
2008-06-26 18:46   ` Junio C Hamano
2008-06-26 21:33     ` Pierre Habouzit
2008-07-22 18:09       ` Jan Hudec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3skv2jzey.fsf@localhost.localdomain \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=madcoder@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.