From: Andi Kleen <ak@muc.de>
To: "Paweâ Sikora" <pluto@pld-linux.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [ix86,x86_64] cpu features.
Date: Fri, 13 Aug 2004 18:11:21 +0200 [thread overview]
Message-ID: <m3smarrpau.fsf@averell.firstfloor.org> (raw)
In-Reply-To: <2sMat-61I-43@gated-at.bofh.it> (Paweâ Sikora's message of "Fri, 13 Aug 2004 17:30:17 +0200")
Paweâ Sikora <pluto@pld-linux.org> writes:
> +++ linux-2.6.8-rc4/arch/i386/kernel/cpu/proc.c 2004-08-13 16:48:53.971370504 +0200
> @@ -44,8 +44,8 @@
> NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
>
> /* Intel-defined (#2) */
> - "pni", NULL, NULL, "monitor", "ds_cpl", NULL, NULL, "tm2",
> - "est", NULL, "cid", NULL, NULL, NULL, NULL, NULL,
> + "sse3", NULL, NULL, "monitor", "ds_cpl", NULL, NULL, "est",
> + "tm2", NULL, "cid", NULL, NULL, NULL, "xtpr", NULL,
You cannot just do the pni -> sse3 rename. That could break existing
applications that read /proc/cpuinfo and parse it. The only way would
be to add a new sse3 flag in addition to pni, but I guess that would
be not worth the ugly special case.
-Andi
next parent reply other threads:[~2004-08-13 16:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2sMat-61I-43@gated-at.bofh.it>
2004-08-13 16:11 ` Andi Kleen [this message]
2004-08-13 17:02 ` [PATCH] [ix86,x86_64] cpu features Paweł Sikora
2004-08-13 17:08 ` Paweł Sikora
2004-08-13 20:14 ` Andi Kleen
2004-08-13 20:29 ` Paweł Sikora
[not found] <200408242233.i7OMXrTd001684@hera.kernel.org>
2004-08-25 0:47 ` [PATCH] ix86,x86_64 " Jeff Garzik
2004-08-13 15:24 [PATCH] [ix86,x86_64] " Paweł Sikora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3smarrpau.fsf@averell.firstfloor.org \
--to=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pluto@pld-linux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.