From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4695C3DA6D for ; Fri, 23 May 2025 09:15:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=3nbRkCTRCyYz5pae49oZ2guk1qkAZjW12Mysc5Gsw/4=; b=kgmy1wZZUIPEvSIocYAtxxS2jU Ew9vhIVzYaH6IPDlCCcWnMPVMbBEsiCcyc1Uv+Xi27sFfBRQTTc+SQr9crbySusFOkbROnx/KZ9eu W1/HsbXrwhxddamamlELK9EtOseAK1u3aiWOwZKhT4EO2DW0bbKGrFmuw8ydqygVA7w3NpSPcAV8g uob8HMR/73JVjpX1C/eJ8b7WL3SNQ1GDh6gfLTzX1y8tRMvwWEahCQYmBV7LbvU5Nq2nfeLT8bjxt KKme6J8LovbFneLBkVfIsVz6kQe3BMYbC1RHC7oLm5p/vTgEsBFm6yZl787oz4Mp2e7m5FUSyhvIb zTmDsQkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uIOUp-00000003Poq-1fnu; Fri, 23 May 2025 09:15:19 +0000 Received: from [195.187.100.5] (helo=ni.piap.pl) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uIOQX-00000003PEW-1JLH; Fri, 23 May 2025 09:10:54 +0000 Received: from t19.piap.pl (OSB1819.piap.pl [10.0.9.19]) by ni.piap.pl (Postfix) with ESMTPS id 0CE57C405A4B; Fri, 23 May 2025 11:10:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 ni.piap.pl 0CE57C405A4B From: Krzysztof =?utf-8?Q?Ha=C5=82asa?= To: Dafna Hirschfeld Cc: Laurent Pinchart , Mauro Carvalho Chehab , Heiko Stuebner , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jacopo Mondi , Paul Elder , Ondrej Jirman , Tomi Valkeinen Subject: [PATCH] media: rkisp1: correct histogram window size Date: Fri, 23 May 2025 11:10:47 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250523_021053_512522_6F958A41 X-CRM114-Status: UNSURE ( 6.22 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Without the patch (i.MX8MP, all-white RGGB-12 full HD input from the sensor, YUV NV12 output from ISP, full range, histogram Y mode). HIST_STEPSIZE =3D 3 (lowest permitted), all weights are set to 1: isp_hist_h_size: 383 (=3D 1920 / 5 - 1) isp_hist_v_size: 215 (=3D 1080 / 5 - 1) histogram_measurement_result[16]: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 229401 Apparently the histogram is missing the last column (3-pixel wide, though only single pixels count) and the last (same idea) row of the input image: 1917 * 1077 / 3 / 3 =3D 229401. E.g. without the patch, the pixels counted in lines are: 0, 3, ... 1914 (which makes 1917/3), and patched: 0, 3, ... 1914, 1917 (which makes 1920/3). The same is true for rows. With the patch applied: isp_hist_h_size: 384 (=3D 1920 / 5) isp_hist_v_size: 216 (=3D 1080 / 5) histogram_measurement_result[16]: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 230400 1920 * 1080 / 3 / 3 =3D 230400 Signed-off-by: Krzysztof Ha=C5=82asa diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c b/drive= rs/media/platform/rockchip/rkisp1/rkisp1-params.c index b28f4140c8a3..ca9b3e711e5f 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c @@ -819,8 +819,8 @@ static void rkisp1_hst_config_v10(struct rkisp1_params = *params, arg->meas_window.v_offs); =20 block_hsize =3D arg->meas_window.h_size / - RKISP1_CIF_ISP_HIST_COLUMN_NUM_V10 - 1; - block_vsize =3D arg->meas_window.v_size / RKISP1_CIF_ISP_HIST_ROW_NUM_V10= - 1; + RKISP1_CIF_ISP_HIST_COLUMN_NUM_V10; + block_vsize =3D arg->meas_window.v_size / RKISP1_CIF_ISP_HIST_ROW_NUM_V10; =20 rkisp1_write(params->rkisp1, RKISP1_CIF_ISP_HIST_H_SIZE_V10, block_hsize); --=20 Krzysztof "Chris" Ha=C5=82asa Sie=C4=87 Badawcza =C5=81ukasiewicz Przemys=C5=82owy Instytut Automatyki i Pomiar=C3=B3w PIAP Al. Jerozolimskie 202, 02-486 Warszawa From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E778C3DA6D for ; Fri, 23 May 2025 09:15:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=BSgHMHDpJYPGqPPOS9R15l+YYDrccB4Bfn75qp4fJxQ=; b=whT3vK3n37HIxB 81jmYJlAWxE90tYZbTGtLSz4GAmsgP8j5dIGiry0zfXcGmSkxy7rXGGK1jwQn0WmuUHchNJ1ILimd FPdOoj5fKJCH/9u7ojPPgKQBAVVIu6CvtXINWcMVb6NGUrqpXW3ZjT1bYYtpDAvAxxQ8QvdW+9P1c zGnzNN89wJrYaIrCctB3+Y4P27XvaGxFCjlQExABhgA/eBIxmX8arO7xSQ2TOFP8lsKLERX6smqDj 2cfpdrTCh2HqszI0DpQWYuQw76HrWWE7e0LJ+qs53MWH3S1z2Ex/xf9/03Mvd4K/7HGAb5B+BHsGP v/9ktxE6BRkapy2vqBKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uIOUp-00000003Pp9-3vp8; Fri, 23 May 2025 09:15:19 +0000 Received: from [195.187.100.5] (helo=ni.piap.pl) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uIOQX-00000003PEW-1JLH; Fri, 23 May 2025 09:10:54 +0000 Received: from t19.piap.pl (OSB1819.piap.pl [10.0.9.19]) by ni.piap.pl (Postfix) with ESMTPS id 0CE57C405A4B; Fri, 23 May 2025 11:10:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 ni.piap.pl 0CE57C405A4B From: Krzysztof =?utf-8?Q?Ha=C5=82asa?= To: Dafna Hirschfeld Cc: Laurent Pinchart , Mauro Carvalho Chehab , Heiko Stuebner , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jacopo Mondi , Paul Elder , Ondrej Jirman , Tomi Valkeinen Subject: [PATCH] media: rkisp1: correct histogram window size Date: Fri, 23 May 2025 11:10:47 +0200 Message-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250523_021053_512522_6F958A41 X-CRM114-Status: UNSURE ( 6.22 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org V2l0aG91dCB0aGUgcGF0Y2ggKGkuTVg4TVAsIGFsbC13aGl0ZSBSR0dCLTEyIGZ1bGwgSEQgaW5w dXQgZnJvbQp0aGUgc2Vuc29yLCBZVVYgTlYxMiBvdXRwdXQgZnJvbSBJU1AsIGZ1bGwgcmFuZ2Us IGhpc3RvZ3JhbSBZIG1vZGUpLgpISVNUX1NURVBTSVpFID0gMyAobG93ZXN0IHBlcm1pdHRlZCks IGFsbCB3ZWlnaHRzIGFyZSBzZXQgdG8gMToKCmlzcF9oaXN0X2hfc2l6ZTogMzgzICg9IDE5MjAg LyA1IC0gMSkKaXNwX2hpc3Rfdl9zaXplOiAyMTUgKD0gMTA4MCAvIDUgLSAxKQpoaXN0b2dyYW1f bWVhc3VyZW1lbnRfcmVzdWx0WzE2XTogMCAwIDAgMCAgMCAwIDAgMCAgMCAwIDAgMCAgMCAwIDAg MjI5NDAxCgpBcHBhcmVudGx5IHRoZSBoaXN0b2dyYW0gaXMgbWlzc2luZyB0aGUgbGFzdCBjb2x1 bW4gKDMtcGl4ZWwgd2lkZSwKdGhvdWdoIG9ubHkgc2luZ2xlIHBpeGVscyBjb3VudCkgYW5kIHRo ZSBsYXN0IChzYW1lIGlkZWEpIHJvdwpvZiB0aGUgaW5wdXQgaW1hZ2U6IDE5MTcgKiAxMDc3IC8g MyAvIDMgPSAyMjk0MDEuCgpFLmcuIHdpdGhvdXQgdGhlIHBhdGNoLCB0aGUgcGl4ZWxzIGNvdW50 ZWQgaW4gbGluZXMgYXJlOgowLCAzLCAuLi4gMTkxNCAod2hpY2ggbWFrZXMgMTkxNy8zKSwgYW5k IHBhdGNoZWQ6CjAsIDMsIC4uLiAxOTE0LCAxOTE3ICh3aGljaCBtYWtlcyAxOTIwLzMpLgpUaGUg c2FtZSBpcyB0cnVlIGZvciByb3dzLgoKV2l0aCB0aGUgcGF0Y2ggYXBwbGllZDoKaXNwX2hpc3Rf aF9zaXplOiAzODQgKD0gMTkyMCAvIDUpCmlzcF9oaXN0X3Zfc2l6ZTogMjE2ICg9IDEwODAgLyA1 KQpoaXN0b2dyYW1fbWVhc3VyZW1lbnRfcmVzdWx0WzE2XTogMCAwIDAgMCAgMCAwIDAgMCAgMCAw IDAgMCAgMCAwIDAgMjMwNDAwCgoxOTIwICogMTA4MCAvIDMgLyAzID0gMjMwNDAwCgpTaWduZWQt b2ZmLWJ5OiBLcnp5c3p0b2YgSGHFgmFzYSA8a2hhbGFzYUBwaWFwLnBsPgoKZGlmZiAtLWdpdCBh L2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vcm9ja2NoaXAvcmtpc3AxL3JraXNwMS1wYXJhbXMuYyBi L2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vcm9ja2NoaXAvcmtpc3AxL3JraXNwMS1wYXJhbXMuYwpp bmRleCBiMjhmNDE0MGM4YTMuLmNhOWIzZTcxMWU1ZiAxMDA2NDQKLS0tIGEvZHJpdmVycy9tZWRp YS9wbGF0Zm9ybS9yb2NrY2hpcC9ya2lzcDEvcmtpc3AxLXBhcmFtcy5jCisrKyBiL2RyaXZlcnMv bWVkaWEvcGxhdGZvcm0vcm9ja2NoaXAvcmtpc3AxL3JraXNwMS1wYXJhbXMuYwpAQCAtODE5LDgg KzgxOSw4IEBAIHN0YXRpYyB2b2lkIHJraXNwMV9oc3RfY29uZmlnX3YxMChzdHJ1Y3Qgcmtpc3Ax X3BhcmFtcyAqcGFyYW1zLAogCQkgICAgIGFyZy0+bWVhc193aW5kb3cudl9vZmZzKTsKIAogCWJs b2NrX2hzaXplID0gYXJnLT5tZWFzX3dpbmRvdy5oX3NpemUgLwotCQkgICAgICBSS0lTUDFfQ0lG X0lTUF9ISVNUX0NPTFVNTl9OVU1fVjEwIC0gMTsKLQlibG9ja192c2l6ZSA9IGFyZy0+bWVhc193 aW5kb3cudl9zaXplIC8gUktJU1AxX0NJRl9JU1BfSElTVF9ST1dfTlVNX1YxMCAtIDE7CisJCSAg ICAgIFJLSVNQMV9DSUZfSVNQX0hJU1RfQ09MVU1OX05VTV9WMTA7CisJYmxvY2tfdnNpemUgPSBh cmctPm1lYXNfd2luZG93LnZfc2l6ZSAvIFJLSVNQMV9DSUZfSVNQX0hJU1RfUk9XX05VTV9WMTA7 CiAKIAlya2lzcDFfd3JpdGUocGFyYW1zLT5ya2lzcDEsIFJLSVNQMV9DSUZfSVNQX0hJU1RfSF9T SVpFX1YxMCwKIAkJICAgICBibG9ja19oc2l6ZSk7CgotLSAKS3J6eXN6dG9mICJDaHJpcyIgSGHF gmFzYQoKU2llxIcgQmFkYXdjemEgxYF1a2FzaWV3aWN6ClByemVteXPFgm93eSBJbnN0eXR1dCBB dXRvbWF0eWtpIGkgUG9taWFyw7N3IFBJQVAKQWwuIEplcm96b2xpbXNraWUgMjAyLCAwMi00ODYg V2Fyc3phd2EKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt cm9ja2NoaXAK