From: Jakub Narebski <jnareb@gmail.com>
To: Pete Harlan <pgit@pcharlan.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fix capitalization of "renamelimit" in docs to agree with code
Date: Sun, 18 Dec 2011 16:51:13 -0800 (PST) [thread overview]
Message-ID: <m3ty4xfkpc.fsf@localhost.localdomain> (raw)
In-Reply-To: <4EEE86AC.2030802@pcharlan.com>
Pete Harlan <pgit@pcharlan.com> writes:
> Signed-off-by: Pete Harlan <pgit@pcharlan.com>
> ---
> The documentation and bash-completion have always capitalized
> "renamelimit" as "renameLimit". The code has always lowercased the
> whole name. Repair the docs.
Key names are *case insensitive* so we can write it in docs in a way
that is more clear, like 'renameLimit'.
Code compares with lowercased key name, so that is why it uses
'renamelimit'.
> @@ -2122,7 +2122,7 @@ _git_config ()
> diff.ignoreSubmodules
> diff.mnemonicprefix
> diff.noprefix
> - diff.renameLimit
> + diff.renamelimit
> diff.renames
> diff.suppressBlankEmpty
> diff.tool
Consitency - why you change diff.renameLimit but not
diff.ignoreSubmodules?
--
Jakub Narebski
next prev parent reply other threads:[~2011-12-19 0:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-19 0:34 [PATCH] Fix capitalization of "renamelimit" in docs to agree with code Pete Harlan
2011-12-19 0:51 ` Jakub Narebski [this message]
2011-12-19 1:02 ` Junio C Hamano
2011-12-19 1:13 ` Pete Harlan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ty4xfkpc.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=pgit@pcharlan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.