From: Krzysztof Halasa <khc@pm.waw.pl>
To: Tracey Dent <tdent48227@gmail.com>
Cc: tytso@mit.edu, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/10] Fs: ext4: ext4: cleaned up the file with checkpatch.pl
Date: Sun, 26 Sep 2010 08:23:25 +0200 [thread overview]
Message-ID: <m3tyld6n1e.fsf@intrepid.localdomain> (raw)
In-Reply-To: <1285439521-2557-5-git-send-email-tdent48227@gmail.com> (Tracey Dent's message of "Sat, 25 Sep 2010 14:31:56 -0400")
Tracey Dent <tdent48227@gmail.com> writes:
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -233,8 +233,7 @@ typedef struct ext4_io_end {
> /*
> * Structure of a blocks group descriptor
> */
> -struct ext4_group_desc
> -{
> +struct ext4_group_desc {
> __le32 bg_block_bitmap_lo; /* Blocks bitmap block */
> __le32 bg_inode_bitmap_lo; /* Inodes bitmap block */
Putting a TAB instead of SPACE before the '{' isn't common here, is it?
> @@ -513,8 +512,8 @@ struct ext4_new_group_data {
> #define EXT4_IOC_GROUP_EXTEND _IOW('f', 7, unsigned long)
> #define EXT4_IOC_GROUP_ADD _IOW('f', 8, struct ext4_new_group_input)
> #define EXT4_IOC_MIGRATE _IO('f', 9)
> - /* note ioctl 10 reserved for an early version of the FIEMAP ioctl */
> - /* note ioctl 11 reserved for filesystem-independent FIEMAP ioctl */
> + /* note ioctl 10 reserved for an early version of the FIEMAP ioctl */
> + /* note ioctl 11 reserved for filesystem-independent FIEMAP ioctl */
> #define EXT4_IOC_ALLOC_DA_BLKS _IO('f', 12)
Doesn't look like an improvement to me.
> static inline __le32 ext4_encode_extra_time(struct timespec *time)
> {
> - return cpu_to_le32((sizeof(time->tv_sec) > 4 ?
> - (time->tv_sec >> 32) & EXT4_EPOCH_MASK : 0) |
> - ((time->tv_nsec << EXT4_EPOCH_BITS) & EXT4_NSEC_MASK));
> + return cpu_to_le32((sizeof(time->tv_sec) > 4 ?
> + (time->tv_sec >> 32) & EXT4_EPOCH_MASK : 0) |
> + ((time->tv_nsec << EXT4_EPOCH_BITS) & EXT4_NSEC_MASK));
Wrong level of indentation.
> static inline void ext4_decode_extra_time(struct timespec *time, __le32 extra)
> {
> - if (sizeof(time->tv_sec) > 4)
> + if (sizeof(time->tv_sec) > 4)
Ditto.
--
Krzysztof Halasa
next prev parent reply other threads:[~2010-09-26 6:23 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-25 18:31 [PATCH 01/10] Fs: ext4: acl.c: fixed indent issue Tracey Dent
2010-09-25 18:31 ` [PATCH 02/10] Fs: ext4: acl.h: whitespace cleanup Tracey Dent
2010-09-26 6:11 ` Krzysztof Halasa
2010-09-25 18:31 ` [PATCH 03/10] Fs: ext: balloc: fixed a few issues that checkpatch.pl was having Tracey Dent
2010-09-25 18:31 ` [PATCH 04/10] Fs: ext4: block_validity: added space around = sign Tracey Dent
2010-09-25 18:31 ` [PATCH 05/10] Fs: ext4: ext4: cleaned up the file with checkpatch.pl Tracey Dent
2010-09-26 6:23 ` Krzysztof Halasa [this message]
2010-09-25 18:31 ` [PATCH 06/10] Fs: ext4: extents: whitespace cleanup Tracey Dent
2010-09-25 18:31 ` [PATCH 07/10] Fs: ext4: file: fixed indent problem Tracey Dent
2010-09-25 18:31 ` [PATCH 08/10] Fs: ext4: ioctl: fixed spacing issue Tracey Dent
2010-09-25 18:32 ` [PATCH 09/10] Fs: ext4: mballoc.c: whitespace cleanup Tracey Dent
2010-09-25 18:32 ` [PATCH 10/10] Fs: ext4: namei: fixed file of checkpatch/pl warnings and errors Tracey Dent
2010-09-26 6:36 ` Krzysztof Halasa
2010-09-26 18:23 ` Ted Ts'o
2010-09-26 18:35 ` Davidlohr Bueso
2010-09-26 19:17 ` Krzysztof Halasa
2010-09-25 23:36 ` [PATCH 01/10] Fs: ext4: acl.c: fixed indent issue Christoph Hellwig
2010-09-25 23:53 ` T Dent
2010-09-25 23:56 ` Christoph Hellwig
2010-09-26 0:01 ` Ted Ts'o
2010-09-26 0:09 ` Joe Perches
2010-09-26 0:32 ` Ted Ts'o
2010-09-26 0:36 ` Ted Ts'o
2010-09-26 0:36 ` Ted Ts'o
2010-09-26 0:50 ` Joe Perches
2010-09-26 0:58 ` Joe Perches
2010-09-26 6:42 ` Krzysztof Halasa
2010-09-26 6:49 ` Joe Perches
2010-09-26 11:31 ` Krzysztof Halasa
2010-09-26 1:04 ` Ted Ts'o
2010-09-26 1:32 ` Joe Perches
2010-09-26 1:53 ` Ted Ts'o
2010-09-26 2:03 ` Joe Perches
2010-09-26 2:10 ` Ted Ts'o
2010-09-26 2:21 ` Ted Ts'o
2010-09-26 2:21 ` Ted Ts'o
2010-09-26 2:45 ` Joe Perches
2010-09-26 2:29 ` Joe Perches
2010-09-26 0:06 ` Joe Perches
2010-09-26 20:06 ` Christoph Hellwig
2010-09-26 22:17 ` Joe Perches
2010-09-25 23:54 ` Ted Ts'o
2010-09-27 13:52 ` Eric Sandeen
2010-09-27 13:52 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3tyld6n1e.fsf@intrepid.localdomain \
--to=khc@pm.waw.pl \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tdent48227@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.