From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=60530 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OLxZV-00083H-93
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 08:06:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <armbru@redhat.com>) id 1OLxZS-0005kb-Pt
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 08:06:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:29845)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <armbru@redhat.com>) id 1OLxZS-0005kM-JL
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 08:06:18 -0400
From: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qdev: Reject duplicate and anti-social
	device IDs
References: <cover.1274612367.git.jan.kiszka@web.de>
	<201006030751.37918.paul@codesourcery.com>
	<m3iq5yx47w.fsf@blackfin.pond.sub.org>
	<201006041628.30920.paul@codesourcery.com>
Date: Tue, 08 Jun 2010 14:06:04 +0200
In-Reply-To: <201006041628.30920.paul@codesourcery.com> (Paul Brook's message
	of "Fri, 4 Jun 2010 16:28:29 +0100")
Message-ID: <m3typdg24z.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Juan Quintela <quintela@redhat.com>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>, Blue Swirl <blauwirbel@gmail.com>, Jan Kiszka <jan.kiszka@web.de>, Gerd Hoffmann <kraxel@redhat.com>, Avi Kivity <avi@redhat.com>

Paul Brook <paul@codesourcery.com> writes:

>> Paul Brook <paul@codesourcery.com> writes:
>> >> Also require IDs to start with a letter to provide for possible future
>> >> extensions.
>> > 
>> > I'd go further than that, and require that user specified IDs match
>> > [A-Za-z][A-Za-z0-9_-]*
>> 
>> I talked with Dan (cc'ed) to make sure we don't trample on existing
>> libvirt usage without need.  What about
>> 
>> [A-Za-z][A-Za-z0-9_-:.]*
>> 
>> i.e. your regexp plus ':' and '.' in the second bracket?
>
> I was deliberately avoiding those as they're often used as separators - we 
> already use ':' in other contexts so there's potential ambiguity and 
> parsing/quoting issues. I'm not aware of any current issues with '.'.

I checked with Dan, and we can outlaw ':'.  I just posted a new patch
that covers all qemu-option IDs, not just qdev.

[...]