From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=41888 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ODaTO-0004jb-2V for qemu-devel@nongnu.org; Sun, 16 May 2010 05:49:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ODaTM-0001nM-RJ for qemu-devel@nongnu.org; Sun, 16 May 2010 05:49:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47046) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ODaTM-0001nI-If for qemu-devel@nongnu.org; Sun, 16 May 2010 05:49:24 -0400 From: Juan Quintela In-Reply-To: <4BEE7F80.2090203@web.de> (Jan Kiszka's message of "Sat, 15 May 2010 13:03:28 +0200") References: <4BEE7F80.2090203@web.de> Date: Sun, 16 May 2010 11:49:22 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH] Put dependency files in proper subdir List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel Jan Kiszka wrote: > From: Jan Kiszka > > This seems to resolve subtle breakages of our build system: > > Dependency files generated for targets like 'dir/foo.o' were saved as > 'foo.d'. Now, if there was also a target 'foo.o', one of the dependency > file was overwritten. Concrete example: libhw*/macio.o vs. > libhw*/ide/macio.o. And this often left a segfaulting build result > behind when changing the "wrong" data structures". > > Fix it by generating proper 'dir/foo.d'. > > Signed-off-by: Jan Kiszka Acked-by: Juan Quintela