From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=33399 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OCyId-0003iT-7c
	for qemu-devel@nongnu.org; Fri, 14 May 2010 13:03:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <armbru@redhat.com>) id 1OCyIX-0000AM-A7
	for qemu-devel@nongnu.org; Fri, 14 May 2010 13:03:46 -0400
Received: from mx1.redhat.com ([209.132.183.28]:1110)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <armbru@redhat.com>) id 1OCyIV-00009q-Ot
	for qemu-devel@nongnu.org; Fri, 14 May 2010 13:03:41 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4EH3cqG029881
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 14 May 2010 13:03:39 -0400
From: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc
References: <1273086712-29163-1-git-send-email-lcapitulino@redhat.com>
	<1273086712-29163-2-git-send-email-lcapitulino@redhat.com>
	<4BEC031D.6020506@redhat.com> <m3pr0yq333.fsf@blackfin.pond.sub.org>
	<4BED6F85.50309@redhat.com>
Date: Fri, 14 May 2010 19:03:36 +0200
In-Reply-To: <4BED6F85.50309@redhat.com> (Avi Kivity's message of "Fri, 14 May
	2010 18:43:01 +0300")
Message-ID: <m3tyqa5sbb.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: bazulay@redhat.com, juzhang@redhat.com, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

Avi Kivity <avi@redhat.com> writes:

> On 05/14/2010 11:50 AM, Markus Armbruster wrote:
>>
>>>> +
>>>> +{ "execute": "migrate_set_speed", "arguments": { "value": 1024 } }
>>>>
>>>>        
>>> Oh, we do have more.
>>>
>>> Please document the units for this value (bits per second)?
>>>      
>> bytes per second?
>>    
>
> Bandwidth is typically measured in bits per second.

The question is what unit the code actually uses.  What it should use is
separate, if valid question.

>>>> +- "bus": identical to the parent's bus number (json-int)
>>>> +- "slot": slot number (json-int)
>>>> +- "function": function number (json-int)
>>>>
>>>>        
>>> Would have been nicer as a nested object (list of buses, each
>>> containing a list of slots, each containing a list of functions).
>>>      
>> We have a list of buses, each containing a list of device functions.
>> Not sure the additional level of nesting you propose buys us anything.
>>    
>
> A slot is the hotpluggable entity.  Open your computer and you can
> actually see them.

QEMU doesn't really know that.

> btw would be good to list empty slots as well.

Why?

> What about PCI domains?

Good point.  Better to provide for them neatly now, instead of kludging
them in later.