From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NVpIl-0006S1-Ck
	for qemu-devel@nongnu.org; Fri, 15 Jan 2010 11:45:35 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NVpIg-0006GQ-PJ
	for qemu-devel@nongnu.org; Fri, 15 Jan 2010 11:45:34 -0500
Received: from [199.232.76.173] (port=45007 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NVpIg-0006G9-H9
	for qemu-devel@nongnu.org; Fri, 15 Jan 2010 11:45:30 -0500
Received: from mx1.redhat.com ([209.132.183.28]:38391)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <armbru@redhat.com>) id 1NVpIf-0008OL-O6
	for qemu-devel@nongnu.org; Fri, 15 Jan 2010 11:45:30 -0500
Received: from int-mx05.intmail.prod.int.phx2.redhat.com
	(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0FGjRVI006394
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 15 Jan 2010 11:45:27 -0500
From: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Fix QEMU_WARN_UNUSED_RESULT
References: <1263556601-15351-1-git-send-email-kwolf@redhat.com>
Date: Fri, 15 Jan 2010 17:45:25 +0100
In-Reply-To: <1263556601-15351-1-git-send-email-kwolf@redhat.com> (Kevin
	Wolf's message of "Fri, 15 Jan 2010 12:56:41 +0100")
Message-ID: <m3tyungvve.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, kraxel@redhat.com

Kevin Wolf <kwolf@redhat.com> writes:

> Since commit 747bbdf7 QEMU_WARN_UNUSED_RESULT is never defined as it is
> conditional on a define from config-host.h which is included only later.
> Include that file earlier to get the warnings back.
>
> Reactivating it unfortunately leads to some warnings about unused qdev_init
> results. These calls are changed to qdev_init_nofail to avoid build failures.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>

The use of qdev_init_nofail() is correct, because the relevant device
init methods can't fail.

Acked-by: Markus Armbruster <armbru@redhat.com>