From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NBXII-0001ms-TE
	for qemu-devel@nongnu.org; Fri, 20 Nov 2009 12:29:14 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NBXIE-0001hz-5w
	for qemu-devel@nongnu.org; Fri, 20 Nov 2009 12:29:14 -0500
Received: from [199.232.76.173] (port=56318 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NBXIE-0001hp-01
	for qemu-devel@nongnu.org; Fri, 20 Nov 2009 12:29:10 -0500
Received: from mx1.redhat.com ([209.132.183.28]:9272)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <armbru@redhat.com>) id 1NBXIC-00052v-G2
	for qemu-devel@nongnu.org; Fri, 20 Nov 2009 12:29:09 -0500
From: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 00/10]: QError v4
References: <1258487037-24950-1-git-send-email-lcapitulino@redhat.com>
	<m33a4bes1c.fsf@crossbow.pond.sub.org>
	<4B04383A.9050101@linux.vnet.ibm.com>
	<20091119023651.GA15128@shareable.org>
	<4B06BC3E.5060806@codemonkey.ws>
Date: Fri, 20 Nov 2009 18:29:03 +0100
In-Reply-To: <4B06BC3E.5060806@codemonkey.ws> (Anthony Liguori's message of
	"Fri, 20 Nov 2009 09:56:46 -0600")
Message-ID: <m3tywpf6lc.fsf@crossbow.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Luiz Capitulino <lcapitulino@redhat.com>, kraxel@redhat.com, qemu-devel@nongnu.org

Anthony Liguori <anthony@codemonkey.ws> writes:

> Jamie Lokier wrote:
>> Anthony Liguori wrote:
>>   
>>> Markus Armbruster wrote:
>>>     
>>>> 3. It falls short of the requirement that clients can easily present a
>>>>   human-readable error description to their human users, regardless of
>>>>   whether they know the error or not.
>>>>        
>>> That's just incorrect.  We provide an example conversion table
>>> that's akin to strerror() or a __repr__ for an exception in Python.
>>>     
>>
>> Markus refers to errors that the client does not know - i.e. when the
>> client is older than qemu, or is not in the same development branch if
>> it's a branched qemu.  Which means the client won't have a fully up to
>> date conversion table.
>>
>> Do you mean qemu provides it's current conversion table to the client
>> over the wire protocol?
>>   
>
> (qemu) format_error "{'class': 'DeviceNotFound', 'data' : {'addr':
> 00:11:22'} }"
> Device 0:11:22 is not present
>
> Is what I'm thinking.  I don't think it's needed but it solves the
> "problem".

Any particular reason not put it into the error object and be done with
it?