From: "Krzysztof Hałasa" <khalasa@piap.pl>
To: Guangshuo Li <lgs201920130244@gmail.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: i2c: ar0521: remove duplicate media entity cleanup
Date: Tue, 15 Sep 2026 13:36:09 +0200 [thread overview]
Message-ID: <m3v786agra.fsf@t19.piap.pl> (raw)
In-Reply-To: <20260915075520.2122757-1-lgs201920130244@gmail.com> (Guangshuo Li's message of "Tue, 15 Sep 2026 15:55:20 +0800")
Hi Guangshuo,
Guangshuo Li <lgs201920130244@gmail.com> writes:
> There is no need to clean up the media entity twice.
Definitely.
Thanks for fixing this.
Acked-by: Krzysztof Hałasa <khalasa@piap.pl>
> Fixes: 852b50aeed15 ("media: On Semi AR0521 sensor driver")
> Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
> --- a/drivers/media/i2c/ar0521.c
> +++ b/drivers/media/i2c/ar0521.c
> @@ -1142,7 +1142,6 @@ static int ar0521_probe(struct i2c_client *client)
>
> disable:
> v4l2_async_unregister_subdev(&sensor->sd);
> - media_entity_cleanup(&sensor->sd.entity);
> free_ctrls:
> v4l2_ctrl_handler_free(&sensor->ctrls.handler);
> entity_cleanup:
--
Krzysztof "Chris" Hałasa
Sieć Badawcza Łukasiewicz
Przemysłowy Instytut Automatyki i Pomiarów PIAP
Al. Jerozolimskie 202, 02-486 Warszawa
prev parent reply other threads:[~2026-09-15 11:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 7:55 [PATCH] media: i2c: ar0521: remove duplicate media entity cleanup Guangshuo Li
2026-09-15 11:36 ` Krzysztof Hałasa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3v786agra.fsf@t19.piap.pl \
--to=khalasa@piap.pl \
--cc=lgs201920130244@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.