From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juan Quintela Subject: Re: [PATCH 07/18] Introduce fault tolerant VM transaction QEMUFile and ft_mode. Date: Wed, 23 Feb 2011 23:16:37 +0100 Message-ID: References: <1298468927-19193-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> <1298468927-19193-8-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> Reply-To: quintela@redhat.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org, kwolf@redhat.com, aliguori@us.ibm.com, mtosatti@redhat.com, ananth@in.ibm.com, mst@redhat.com, dlaor@redhat.com, vatsa@linux.vnet.ibm.com, blauwirbel@gmail.com, ohmura.kei@lab.ntt.co.jp, avi@redhat.com, pbonzini@redhat.com, psuriset@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com To: Yoshiaki Tamura Return-path: Received: from mx1.redhat.com ([209.132.183.28]:46332 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753865Ab1BWWSV (ORCPT ); Wed, 23 Feb 2011 17:18:21 -0500 In-Reply-To: <1298468927-19193-8-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> (Yoshiaki Tamura's message of "Wed, 23 Feb 2011 22:48:36 +0900") Sender: kvm-owner@vger.kernel.org List-ID: Yoshiaki Tamura wrote: > This code implements VM transaction protocol. Like buffered_file, it > sits between savevm and migration layer. With this architecture, VM > transaction protocol is implemented mostly independent from other > existing code. Could you explain what is the difference with buffered_file.c? I am fixing problems on buffered_file, and having something that copies lot of code from there makes me nervous. > +typedef ssize_t (FtTransPutBufferFunc)(void *opaque, const void *data, size_t size); Can we get some sharing here? typedef ssize_t (BufferedPutFunc)(void *opaque, const void *data, size_t size); There are not so much types for a write function that the 1st element is one opaque :p Later, Juan. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=36184 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PsNOG-0001tI-FE for qemu-devel@nongnu.org; Wed, 23 Feb 2011 17:41:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PsN2I-0001rN-Jo for qemu-devel@nongnu.org; Wed, 23 Feb 2011 17:18:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:29039) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PsN2I-0001r3-21 for qemu-devel@nongnu.org; Wed, 23 Feb 2011 17:18:18 -0500 From: Juan Quintela In-Reply-To: <1298468927-19193-8-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> (Yoshiaki Tamura's message of "Wed, 23 Feb 2011 22:48:36 +0900") References: <1298468927-19193-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> <1298468927-19193-8-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> Date: Wed, 23 Feb 2011 23:16:37 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH 07/18] Introduce fault tolerant VM transaction QEMUFile and ft_mode. Reply-To: quintela@redhat.com List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yoshiaki Tamura Cc: kwolf@redhat.com, aliguori@us.ibm.com, dlaor@redhat.com, ananth@in.ibm.com, kvm@vger.kernel.org, mst@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org, vatsa@linux.vnet.ibm.com, blauwirbel@gmail.com, ohmura.kei@lab.ntt.co.jp, avi@redhat.com, pbonzini@redhat.com, psuriset@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com Yoshiaki Tamura wrote: > This code implements VM transaction protocol. Like buffered_file, it > sits between savevm and migration layer. With this architecture, VM > transaction protocol is implemented mostly independent from other > existing code. Could you explain what is the difference with buffered_file.c? I am fixing problems on buffered_file, and having something that copies lot of code from there makes me nervous. > +typedef ssize_t (FtTransPutBufferFunc)(void *opaque, const void *data, size_t size); Can we get some sharing here? typedef ssize_t (BufferedPutFunc)(void *opaque, const void *data, size_t size); There are not so much types for a write function that the 1st element is one opaque :p Later, Juan.