From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=57579 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ODvpm-0005rc-AB
	for qemu-devel@nongnu.org; Mon, 17 May 2010 04:37:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <armbru@redhat.com>) id 1ODvpk-0000Le-Om
	for qemu-devel@nongnu.org; Mon, 17 May 2010 04:37:58 -0400
Received: from mx1.redhat.com ([209.132.183.28]:11741)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <armbru@redhat.com>) id 1ODvpk-0000LZ-HE
	for qemu-devel@nongnu.org; Mon, 17 May 2010 04:37:56 -0400
From: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] mingw32 compile fixes
References: <AANLkTininP15fyhM1nE_SwQdLk9z_XW8tPWZagB25sCU@mail.gmail.com>
	<4BEF1489.6000907@mail.berlios.de>
	<AANLkTinYfoAXnNqvvBls6IEA3beM4M0AeREXibVb_2tP@mail.gmail.com>
Date: Mon, 17 May 2010 10:37:51 +0200
In-Reply-To: <AANLkTinYfoAXnNqvvBls6IEA3beM4M0AeREXibVb_2tP@mail.gmail.com>
	(Blue Swirl's message of "Sun, 16 May 2010 11:24:59 +0300")
Message-ID: <m3vdamvs80.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

Blue Swirl <blauwirbel@gmail.com> writes:

> On 5/16/10, Stefan Weil <weil@mail.berlios.de> wrote:
>> Am 15.05.2010 22:49, schrieb Blue Swirl:
>>
>>
>> > Hi,
>> >
>> > With this mingw32 compiler:
>> >
>> > $ i586-mingw32msvc-gcc -v
>> > Using built-in specs.
>> > Target: i586-mingw32msvc
>> > Configured with:
[...]
>> > build will not succeed because formats %zd, %zu, %hh, %lld, %llx and
>> > %llu are not known by the compiler.
>> >
>> > Any %ll* use is clearly a bug, we have PRI*64 macros just for this
>> purpose.
>> >
>> > For %hh and %z there may be better ways than these patches.
>> >
>> > With the patches I can build working Win32 binaries and there are no
>> warnings.
[...]
>>  It's a compiler bug that the compiler does not know these format strings.
>>  The code works nevertheless (at least with mingw libraries which are
>>  not too old) because the format strings are interpreted by the C runtime
>>  library.
>>
>>  Is it worth changing a lot of files when we can expect a newer mingw
>>  compiler version which works correctly for standard format strings?
>
> When and if that version becomes popular, PRIz* and the %hh hack could
> be removed or a compiler check could be added. But I don't think it's
> worth it, the macros are easy to use.

They're also ugly as sin.