All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: Stephan Beyer <s-beyer@gmx.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] t/: Use "test_must_fail git" instead of "! git"
Date: Sat, 12 Jul 2008 09:04:21 -0700 (PDT)	[thread overview]
Message-ID: <m3vdzbccoq.fsf@localhost.localdomain> (raw)
In-Reply-To: <1215877672-17049-2-git-send-email-s-beyer@gmx.net>

Stephan Beyer <s-beyer@gmx.net> writes:

> This patch changes every occurrence of "! git" -- with the meaning
> that a git call has to fail -- into "test_must_fail git".
> 
> This is useful to

>  - advertise the use of "test_must_fail" for new tests.

Hmmm... I think advertising the use of 'test_must_fail' would be
the best served by adding information about this function to
t/README

-- 
Jakub Narebski
Poland
ShadeHawk on #git

  reply	other threads:[~2008-07-12 16:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-12 15:47 [PATCH 1/2] t/test-lib.sh: Let test_must_fail fail on signals only Stephan Beyer
2008-07-12 15:47 ` [PATCH 2/2] t/: Use "test_must_fail git" instead of "! git" Stephan Beyer
2008-07-12 16:04   ` Jakub Narebski [this message]
2008-07-12 21:43     ` Stephan Beyer
2008-07-12 21:30   ` [SQUASH PATCH] t9001: " Stephan Beyer
2008-07-16  5:18 ` [PATCH 1/2] t/test-lib.sh: Let test_must_fail fail on signals only Jeff King
2008-07-16  5:54   ` Junio C Hamano
2008-07-17  5:18     ` Jeff King
2008-07-17  5:38       ` Junio C Hamano
2008-07-17  6:01         ` Jeff King
2008-07-17  6:31           ` Junio C Hamano
2008-07-17  6:38             ` Jeff King
2008-07-17  7:22               ` Johannes Sixt
2008-07-17  7:25                 ` Junio C Hamano
2008-07-16 11:57   ` Stephan Beyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3vdzbccoq.fsf@localhost.localdomain \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=s-beyer@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.