From: Jakub Narebski <jnareb@gmail.com>
To: "Fernando J. Pereda" <ferdy@ferdyx.org>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Skip unwritable tests for root
Date: Mon, 30 Jun 2008 00:39:26 -0700 (PDT) [thread overview]
Message-ID: <m3vdzrgymx.fsf@localhost.localdomain> (raw)
In-Reply-To: <1214809551-14603-1-git-send-email-ferdy@ferdyx.org>
"Fernando J. Pereda" <ferdy@ferdyx.org> writes:
> +if test "$(id -u)" -eq 0
> +then
> + test_expect_success 'root writes to unwritable places, skipping test' :
> + test_done
> + exit
> +fi
Yet another place that would profit from test_skip in test-lib.sh...
(Junio uses "say skip" instead of "test_expect_success" in the place
like above here).
--
Jakub Narebski
Poland
ShadeHawk on #git
next prev parent reply other threads:[~2008-06-30 7:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-30 7:05 [PATCH] Skip unwritable tests for root Fernando J. Pereda
2008-06-30 7:39 ` Jakub Narebski [this message]
2008-06-30 9:08 ` Junio C Hamano
2008-06-30 9:27 ` Fernando J. Pereda
2008-07-07 19:14 ` Lea Wiemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3vdzrgymx.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=ferdy@ferdyx.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.