All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Osterlund <petero2@telia.com>
To: balagi@justmail.de
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH] 2.6.19-rc2-mm2 pktcdvd: add sysfs and debugfs interface
Date: 22 Oct 2006 19:42:34 +0200	[thread overview]
Message-ID: <m3vemcdz79.fsf@telia.com> (raw)
In-Reply-To: <op.tht1yvsaiudtyh@master>

"Thomas Maier" <balagi@justmail.de> writes:

> this patch adds a sysfs and debugfs interface
> to the pktcdvd driver.
> The procfs interface is not modified!

Calling the character device interface "procfs interface" is
misleading, so I disagree with this part of the patch:

+  Note: pktsetup uses the pktcdvd procfs interface!

The only connection pktsetup has with procfs is that it reads the
character device minor number from /proc/misc. If that number was
available somewhere else or if udev created /dev/pktcdvd/control
automatically, pktsetup wouldn't need /proc at all.

Actually, checking my FC5 installation, /dev/pktcdvd/control is
created automatically when the driver is loaded, so the /proc code in
pktsetup is only needed to cope with older distributions.

-- 
Peter Osterlund - petero2@telia.com
http://web.telia.com/~u89404340

  reply	other threads:[~2006-10-22 17:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-22 17:17 [PATCH] 2.6.19-rc2-mm2 pktcdvd: add sysfs and debugfs interface Thomas Maier
2006-10-22 17:42 ` Peter Osterlund [this message]
2006-10-22 20:07   ` Peter Osterlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3vemcdz79.fsf@telia.com \
    --to=petero2@telia.com \
    --cc=akpm@osdl.org \
    --cc=balagi@justmail.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.