All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Jaehoon Chung <jh80.chung@samsung.com>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Maya Erez <merez@codeaurora.org>,
	Konstantin Dorfman <kdorfman@codeaurora.org>,
	Ulf Hansson <ulf.hansson@stericsson.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Per FORLIN <per.forlin@stericsson.com>,
	"svenkatr@ti.com" <svenkatr@ti.com>,
	Saugata Das <saugata.das@linaro.org>,
	Hanumath Prasad <hanumath.prasad@stericsson.com>,
	Sebastian Rasmussen <sebras@gmail.com>,
	"Dong, Chuanxiao" <chuanxiao.dong@intel.com>,
	Minchan Kim <minchan@kernel.org>
Subject: Re: [PATCH v12] mmc: support BKOPS feature for eMMC
Date: Mon, 17 Sep 2012 06:30:46 -0400	[thread overview]
Message-ID: <m3wqztx7op.fsf@pullcord.laptop.org> (raw)
In-Reply-To: <5056E25A.6070207@samsung.com> (Jaehoon Chung's message of "Mon, 17 Sep 2012 17:42:02 +0900")

Hi Jaehoon,

On Mon, Sep 17 2012, Jaehoon Chung wrote:
> @@ -2334,7 +2471,13 @@ int mmc_suspend_host(struct mmc_host *host)
>  	mmc_bus_get(host);
>  	if (host->bus_ops && !host->bus_dead) {
>  
> -		if (host->bus_ops->suspend)
> +		if (host->bus_ops->suspend) {
> +			if (mmc_card_doing_bkops(host->card)) {
> +				err = mmc_stop_bkops(host->card);
> +				if (err)
> +					goto out;
> +			}
> +		}
>  			err = host->bus_ops->suspend(host);
>  
>  		if (err == -ENOSYS || !host->bus_ops->resume) {

Something's gone very wrong with the closing brace here.  Maybe you want
the closing brace to be a line later than it is?

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

  reply	other threads:[~2012-09-17 10:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-17  8:42 [PATCH v12] mmc: support BKOPS feature for eMMC Jaehoon Chung
2012-09-17 10:30 ` Chris Ball [this message]
2012-09-17 10:38   ` Jaehoon Chung
2012-09-17 10:44     ` [RESEND PATCH " Jaehoon Chung
2012-09-17 12:21       ` Chris Ball
2012-09-17 23:36         ` Jaehoon Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3wqztx7op.fsf@pullcord.laptop.org \
    --to=cjb@laptop.org \
    --cc=adrian.hunter@intel.com \
    --cc=chuanxiao.dong@intel.com \
    --cc=hanumath.prasad@stericsson.com \
    --cc=jh80.chung@samsung.com \
    --cc=kdorfman@codeaurora.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=merez@codeaurora.org \
    --cc=minchan@kernel.org \
    --cc=per.forlin@stericsson.com \
    --cc=saugata.das@linaro.org \
    --cc=sebras@gmail.com \
    --cc=svenkatr@ti.com \
    --cc=ulf.hansson@stericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.