From: Jakub Narebski <jnareb@gmail.com>
To: Jamey Sharp <jamey@minilop.net>
Cc: git@vger.kernel.org, Josh Triplett <josh@joshtriplett.org>
Subject: Re: [PATCHv4 1/4] Refactor for_each_ref variants to use for_each_ref_in and avoid magic numbers
Date: Fri, 03 Jun 2011 01:33:21 -0700 (PDT) [thread overview]
Message-ID: <m3wrh3wc0x.fsf@localhost.localdomain> (raw)
In-Reply-To: <1306887870-3875-1-git-send-email-jamey@minilop.net>
This patch series would surely benefit from a cover letter...
Jamey Sharp <jamey@minilop.net> writes:
> From: Josh Triplett <josh@joshtriplett.org>
>
> Several variants of the for_each_ref functions call do_for_each_ref with
> both a fixed string prefix and the hardcoded length of that prefix.
> Furthermore, for_each_ref and for_each_ref_submodule passed "refs/" but
> a length of 0, which caused do_for_each_ref to ignore the "refs/".
[...]
--
Jakub Narebski
Poland
ShadeHawk on #git
prev parent reply other threads:[~2011-06-03 8:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 0:24 [PATCHv4 1/4] Refactor for_each_ref variants to use for_each_ref_in and avoid magic numbers Jamey Sharp
2011-06-01 0:24 ` [PATCHv4 2/4] Add infrastructure for ref namespaces Jamey Sharp
2011-06-02 22:44 ` Junio C Hamano
2011-06-02 23:36 ` Josh Triplett
2011-06-03 2:51 ` Junio C Hamano
2011-06-03 17:26 ` Josh Triplett
2011-06-03 8:35 ` Jakub Narebski
2011-06-03 21:01 ` Josh Triplett
2011-06-08 9:41 ` Jakub Narebski
2011-06-09 3:38 ` Josh Triplett
2011-06-09 9:09 ` Jakub Narebski
2011-06-01 0:24 ` [PATCHv4 3/4] Support ref namespaces for remote repositories via upload-pack and receive-pack Jamey Sharp
2011-06-02 23:05 ` Junio C Hamano
2011-06-03 0:06 ` josh
2011-06-03 16:33 ` Junio C Hamano
2011-06-01 0:24 ` [PATCHv4 4/4] Add documentation for ref namespaces Jamey Sharp
2011-06-02 20:36 ` [PATCHv4 1/4] Refactor for_each_ref variants to use for_each_ref_in and avoid magic numbers Junio C Hamano
2011-06-02 20:57 ` Josh Triplett
2011-06-02 23:29 ` Junio C Hamano
2011-06-03 8:33 ` Jakub Narebski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3wrh3wc0x.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=jamey@minilop.net \
--cc=josh@joshtriplett.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.