From: Krzysztof Halasa <khc@pm.waw.pl>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: akpm@osdl.org, jgarzik@pobox.com, linux-kernel@vger.kernel.org,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] pata_amd: Check enable bits on Nvidia
Date: Wed, 13 Sep 2006 21:12:25 +0200 [thread overview]
Message-ID: <m3wt871syu.fsf@defiant.localdomain> (raw)
In-Reply-To: <1158077643.6780.45.camel@localhost.localdomain> (Alan Cox's message of "Tue, 12 Sep 2006 17:14:03 +0100")
Alan Cox <alan@lxorguk.ukuu.org.uk> writes:
> +++ linux-2.6.18-rc6-mm1/drivers/ata/pata_amd.c 2006-09-11 17:17:19.000000000 +0100
> @@ -25,7 +25,7 @@
> #include <linux/libata.h>
>
> #define DRV_NAME "pata_amd"
> -#define DRV_VERSION "0.2.2"
> +#define DRV_VERSION "0.2.3"
>
> /**
> * timing_setup - shared timing computation and load
> @@ -253,11 +253,22 @@
>
> static int nv_pre_reset(struct ata_port *ap) {
> static const u8 bitmask[2] = {0x03, 0xC0};
> + static const struct pci_bits nv_enable_bits[] = {
> + { 0x50, 1, 0x02, 0x02 },
> + { 0x50, 1, 0x01, 0x01 }
> + };
>
> struct pci_dev *pdev = to_pci_dev(ap->host->dev);
> u8 ata66;
> u16 udma;
>
> + if (!pci_test_config_bits(pdev, &nv_enable_bits[ap->port_no])) {
> + ata_port_disable(ap);
> + printk(KERN_INFO "ata%u: port disabled. ignoring.\n", ap->id);
> + return 0;
> + }
> +
> +
Well, it's now a bit better :-)
ata4: port disabled. ignoring.
ata4: SRST failed (status 0xFF)
ata4: SRST failed (err_mask=0x100)
ata4: softreset failed, retrying in 5 secs
ata4: SRST failed (status 0xFF)
ata4: SRST failed (err_mask=0x100)
ata4: softreset failed, retrying in 5 secs
ata4: SRST failed (status 0xFF)
ata4: SRST failed (err_mask=0x100)
ata4: reset failed, giving up
--
Krzysztof Halasa
prev parent reply other threads:[~2006-09-13 19:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-12 16:14 [PATCH] pata_amd: Check enable bits on Nvidia Alan Cox
2006-09-13 19:12 ` Krzysztof Halasa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3wt871syu.fsf@defiant.localdomain \
--to=khc@pm.waw.pl \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.