* [PATCH] arm-bsp/optee: bump corstone1000 to v3.20
@ 2023-03-29 16:16 Rui Miguel Silva
[not found] ` <CANPvuR=mFEJ-03fo5JZcW-+oyKH5i+hzf+Jm4E3r37uxeRRgTQ@mail.gmail.com>
2023-03-30 23:17 ` Jon Mason
0 siblings, 2 replies; 6+ messages in thread
From: Rui Miguel Silva @ 2023-03-29 16:16 UTC (permalink / raw)
To: meta-arm; +Cc: Rui Miguel Silva
Bump the preferred corstone1000 to v3.20, drop patch
that is already included in this version.
Create the 3.20 bbappend and remove the entry in 3.18 bbappend.
Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
---
.../conf/machine/include/corstone1000.inc | 2 +-
.../0004-Handle-logging-syscall.patch | 33 -------------------
.../optee/optee-os-corstone1000-common.inc | 8 -----
.../optee/optee-os_3.18.0.bbappend | 1 -
.../optee/optee-os_3.20.0.bbappend | 6 ++++
5 files changed, 7 insertions(+), 43 deletions(-)
delete mode 100644 meta-arm-bsp/recipes-security/optee/files/optee-os/corstone1000/0004-Handle-logging-syscall.patch
create mode 100644 meta-arm-bsp/recipes-security/optee/optee-os_3.20.0.bbappend
diff --git a/meta-arm-bsp/conf/machine/include/corstone1000.inc b/meta-arm-bsp/conf/machine/include/corstone1000.inc
index 7f25cd54455f..3915d18b5627 100644
--- a/meta-arm-bsp/conf/machine/include/corstone1000.inc
+++ b/meta-arm-bsp/conf/machine/include/corstone1000.inc
@@ -34,7 +34,7 @@ UBOOT_ARCH = "arm"
UBOOT_EXTLINUX = "0"
#optee
-PREFERRED_VERSION_optee-os ?= "3.18.%"
+PREFERRED_VERSION_optee-os ?= "3.20.%"
PREFERRED_VERSION_optee-client ?= "3.18.%"
EXTRA_IMAGEDEPENDS += "optee-os"
OPTEE_ARCH = "arm64"
diff --git a/meta-arm-bsp/recipes-security/optee/files/optee-os/corstone1000/0004-Handle-logging-syscall.patch b/meta-arm-bsp/recipes-security/optee/files/optee-os/corstone1000/0004-Handle-logging-syscall.patch
deleted file mode 100644
index 356be9e04f9e..000000000000
--- a/meta-arm-bsp/recipes-security/optee/files/optee-os/corstone1000/0004-Handle-logging-syscall.patch
+++ /dev/null
@@ -1,33 +0,0 @@
-Upstream-Status: Pending [Not submitted to upstream yet]
-Signed-off-by: Vishnu Banavath <vishnu.banavath@arm.com>
-
-From b3fde6c2e1a950214f760ab9f194f3a6572292a8 Mon Sep 17 00:00:00 2001
-From: Balint Dobszay <balint.dobszay@arm.com>
-Date: Fri, 15 Jul 2022 13:45:54 +0200
-Subject: [PATCH] Handle logging syscall
-
-Signed-off-by: Balint Dobszay <balint.dobszay@arm.com>
-Change-Id: Ib8151cc9c66aea8bcc8fe8b1ecdc3f9f9c5f14e4
-
-%% original patch: 0004-Handle-logging-syscall.patch
-
-diff --git a/core/arch/arm/kernel/spmc_sp_handler.c b/core/arch/arm/kernel/spmc_sp_handler.c
-index e0fa0aa6..c7a45387 100644
---- a/core/arch/arm/kernel/spmc_sp_handler.c
-+++ b/core/arch/arm/kernel/spmc_sp_handler.c
-@@ -1004,6 +1004,12 @@ void spmc_sp_msg_handler(struct thread_smc_args *args,
- ffa_mem_reclaim(args, caller_sp);
- sp_enter(args, caller_sp);
- break;
-+ case 0xdeadbeef:
-+ ts_push_current_session(&caller_sp->ts_sess);
-+ IMSG("%s", (char *)args->a1);
-+ ts_pop_current_session();
-+ sp_enter(args, caller_sp);
-+ break;
- default:
- EMSG("Unhandled FFA function ID %#"PRIx32,
- (uint32_t)args->a0);
---
-2.17.1
-
diff --git a/meta-arm-bsp/recipes-security/optee/optee-os-corstone1000-common.inc b/meta-arm-bsp/recipes-security/optee/optee-os-corstone1000-common.inc
index 71b5ee62b902..30f99666626c 100644
--- a/meta-arm-bsp/recipes-security/optee/optee-os-corstone1000-common.inc
+++ b/meta-arm-bsp/recipes-security/optee/optee-os-corstone1000-common.inc
@@ -1,15 +1,7 @@
-SRCREV = "42f6617108fa43712652ef52f9d5b4ec5b2665f8"
-PV = "3.18.0+git${SRCPV}"
-
SRC_URI:remove = " \
file://0003-core-link-add-no-warn-rwx-segments.patch \
"
-FILESEXTRAPATHS:prepend := "${THISDIR}/files/optee-os/corstone1000:"
-SRC_URI:append = " \
- file://0004-Handle-logging-syscall.patch \
- "
-
COMPATIBLE_MACHINE = "corstone1000"
OPTEEMACHINE = "corstone1000"
diff --git a/meta-arm-bsp/recipes-security/optee/optee-os_3.18.0.bbappend b/meta-arm-bsp/recipes-security/optee/optee-os_3.18.0.bbappend
index 4b03985ac97a..bc933dd54c48 100644
--- a/meta-arm-bsp/recipes-security/optee/optee-os_3.18.0.bbappend
+++ b/meta-arm-bsp/recipes-security/optee/optee-os_3.18.0.bbappend
@@ -3,6 +3,5 @@
MACHINE_OPTEE_OS_REQUIRE ?= ""
MACHINE_OPTEE_OS_REQUIRE:n1sdp = "optee-os-n1sdp.inc"
MACHINE_OPTEE_OS_REQUIRE:tc = "optee-os-tc.inc"
-MACHINE_OPTEE_OS_REQUIRE:corstone1000 = "optee-os-corstone1000-common.inc"
require ${MACHINE_OPTEE_OS_REQUIRE}
diff --git a/meta-arm-bsp/recipes-security/optee/optee-os_3.20.0.bbappend b/meta-arm-bsp/recipes-security/optee/optee-os_3.20.0.bbappend
new file mode 100644
index 000000000000..e732c80f880b
--- /dev/null
+++ b/meta-arm-bsp/recipes-security/optee/optee-os_3.20.0.bbappend
@@ -0,0 +1,6 @@
+# Machine specific configurations
+
+MACHINE_OPTEE_OS_REQUIRE ?= ""
+MACHINE_OPTEE_OS_REQUIRE:corstone1000 = "optee-os-corstone1000-common.inc"
+
+require ${MACHINE_OPTEE_OS_REQUIRE}
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [meta-arm] [PATCH] arm-bsp/optee: bump corstone1000 to v3.20
[not found] ` <m31ql7xtb2.fsf@gmail.com>
@ 2023-03-30 6:41 ` Jose Quaresma
2023-03-30 7:14 ` Rui Miguel Silva
0 siblings, 1 reply; 6+ messages in thread
From: Jose Quaresma @ 2023-03-30 6:41 UTC (permalink / raw)
To: meta-arm; +Cc: Rui Miguel Silva
[-- Attachment #1: Type: text/plain, Size: 7301 bytes --]
Hi,
Reply directly to Rui but not for the mailing list so forward it.
Rui Miguel Silva <rui.silva@linaro.org> escreveu no dia quarta, 29/03/2023
à(s) 20:15:
> Oi Jose,
>
> Thanks for the review.
>
> Jose Quaresma <quaresma.jose@gmail.com> writes:
>
> > Hi Rui,
> >
> > Rui Miguel Silva <rui.silva@linaro.org> escreveu no dia quarta,
> 29/03/2023
> > à(s) 17:15:
> >
> >> Bump the preferred corstone1000 to v3.20, drop patch
> >> that is already included in this version.
> >> Create the 3.20 bbappend and remove the entry in 3.18 bbappend.
> >>
> >> Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
> >> ---
> >> .../conf/machine/include/corstone1000.inc | 2 +-
> >> .../0004-Handle-logging-syscall.patch | 33 -------------------
> >> .../optee/optee-os-corstone1000-common.inc | 8 -----
> >> .../optee/optee-os_3.18.0.bbappend | 1 -
> >> .../optee/optee-os_3.20.0.bbappend | 6 ++++
> >> 5 files changed, 7 insertions(+), 43 deletions(-)
> >> delete mode 100644
> >>
> meta-arm-bsp/recipes-security/optee/files/optee-os/corstone1000/0004-Handle-logging-syscall.patch
> >> create mode 100644
> >> meta-arm-bsp/recipes-security/optee/optee-os_3.20.0.bbappend
> >>
> >> diff --git a/meta-arm-bsp/conf/machine/include/corstone1000.inc
> >> b/meta-arm-bsp/conf/machine/include/corstone1000.inc
> >> index 7f25cd54455f..3915d18b5627 100644
> >> --- a/meta-arm-bsp/conf/machine/include/corstone1000.inc
> >> +++ b/meta-arm-bsp/conf/machine/include/corstone1000.inc
> >> @@ -34,7 +34,7 @@ UBOOT_ARCH = "arm"
> >> UBOOT_EXTLINUX = "0"
> >>
> >> #optee
> >> -PREFERRED_VERSION_optee-os ?= "3.18.%"
> >> +PREFERRED_VERSION_optee-os ?= "3.20.%"
> >> PREFERRED_VERSION_optee-client ?= "3.18.%"
> >> EXTRA_IMAGEDEPENDS += "optee-os"
> >> OPTEE_ARCH = "arm64"
> >> diff --git
> >>
> a/meta-arm-bsp/recipes-security/optee/files/optee-os/corstone1000/0004-Handle-logging-syscall.patch
> >>
> b/meta-arm-bsp/recipes-security/optee/files/optee-os/corstone1000/0004-Handle-logging-syscall.patch
> >> deleted file mode 100644
> >> index 356be9e04f9e..000000000000
> >> ---
> >>
> a/meta-arm-bsp/recipes-security/optee/files/optee-os/corstone1000/0004-Handle-logging-syscall.patch
> >> +++ /dev/null
> >> @@ -1,33 +0,0 @@
> >> -Upstream-Status: Pending [Not submitted to upstream yet]
> >> -Signed-off-by: Vishnu Banavath <vishnu.banavath@arm.com>
> >> -
> >> -From b3fde6c2e1a950214f760ab9f194f3a6572292a8 Mon Sep 17 00:00:00 2001
> >> -From: Balint Dobszay <balint.dobszay@arm.com>
> >> -Date: Fri, 15 Jul 2022 13:45:54 +0200
> >> -Subject: [PATCH] Handle logging syscall
> >> -
> >> -Signed-off-by: Balint Dobszay <balint.dobszay@arm.com>
> >> -Change-Id: Ib8151cc9c66aea8bcc8fe8b1ecdc3f9f9c5f14e4
> >> -
> >> -%% original patch: 0004-Handle-logging-syscall.patch
> >> -
> >> -diff --git a/core/arch/arm/kernel/spmc_sp_handler.c
> >> b/core/arch/arm/kernel/spmc_sp_handler.c
> >> -index e0fa0aa6..c7a45387 100644
> >> ---- a/core/arch/arm/kernel/spmc_sp_handler.c
> >> -+++ b/core/arch/arm/kernel/spmc_sp_handler.c
> >> -@@ -1004,6 +1004,12 @@ void spmc_sp_msg_handler(struct thread_smc_args
> >> *args,
> >> - ffa_mem_reclaim(args, caller_sp);
> >> - sp_enter(args, caller_sp);
> >> - break;
> >> -+ case 0xdeadbeef:
> >> -+ ts_push_current_session(&caller_sp->ts_sess);
> >> -+ IMSG("%s", (char *)args->a1);
> >> -+ ts_pop_current_session();
> >> -+ sp_enter(args, caller_sp);
> >> -+ break;
> >> - default:
> >> - EMSG("Unhandled FFA function ID %#"PRIx32,
> >> - (uint32_t)args->a0);
> >> ---
> >> -2.17.1
> >> -
> >> diff --git
> >> a/meta-arm-bsp/recipes-security/optee/optee-os-corstone1000-common.inc
> >> b/meta-arm-bsp/recipes-security/optee/optee-os-corstone1000-common.inc
> >> index 71b5ee62b902..30f99666626c 100644
> >> ---
> a/meta-arm-bsp/recipes-security/optee/optee-os-corstone1000-common.inc
> >> +++
> b/meta-arm-bsp/recipes-security/optee/optee-os-corstone1000-common.inc
> >> @@ -1,15 +1,7 @@
> >> -SRCREV = "42f6617108fa43712652ef52f9d5b4ec5b2665f8"
> >> -PV = "3.18.0+git${SRCPV}"
> >> -
> >> SRC_URI:remove = " \
> >> file://0003-core-link-add-no-warn-rwx-segments.patch
> \
> >> "
> >>
> >> -FILESEXTRAPATHS:prepend := "${THISDIR}/files/optee-os/corstone1000:"
> >> -SRC_URI:append = " \
> >> - file://0004-Handle-logging-syscall.patch \
> >> - "
> >> -
> >> COMPATIBLE_MACHINE = "corstone1000"
> >>
> >> OPTEEMACHINE = "corstone1000"
> >> diff --git
> a/meta-arm-bsp/recipes-security/optee/optee-os_3.18.0.bbappend
> >> b/meta-arm-bsp/recipes-security/optee/optee-os_3.18.0.bbappend
> >> index 4b03985ac97a..bc933dd54c48 100644
> >> --- a/meta-arm-bsp/recipes-security/optee/optee-os_3.18.0.bbappend
> >> +++ b/meta-arm-bsp/recipes-security/optee/optee-os_3.18.0.bbappend
> >> @@ -3,6 +3,5 @@
> >> MACHINE_OPTEE_OS_REQUIRE ?= ""
> >> MACHINE_OPTEE_OS_REQUIRE:n1sdp = "optee-os-n1sdp.inc"
> >> MACHINE_OPTEE_OS_REQUIRE:tc = "optee-os-tc.inc"
> >> -MACHINE_OPTEE_OS_REQUIRE:corstone1000 =
> "optee-os-corstone1000-common.inc"
> >>
> >> require ${MACHINE_OPTEE_OS_REQUIRE}
> >> diff --git
> a/meta-arm-bsp/recipes-security/optee/optee-os_3.20.0.bbappend
> >> b/meta-arm-bsp/recipes-security/optee/optee-os_3.20.0.bbappend
> >> new file mode 100644
> >> index 000000000000..e732c80f880b
> >> --- /dev/null
> >> +++ b/meta-arm-bsp/recipes-security/optee/optee-os_3.20.0.bbappend
> >> @@ -0,0 +1,6 @@
> >> +# Machine specific configurations
> >> +
> >> +MACHINE_OPTEE_OS_REQUIRE ?= ""
> >> +MACHINE_OPTEE_OS_REQUIRE:corstone1000 =
> "optee-os-corstone1000-common.inc"
> >> +
> >> +require ${MACHINE_OPTEE_OS_REQUIRE}
> >>
> >
> > This will generate a bitbake parse error for other machines than
> > corstone1000.
> >
> > Jose
>
> This pattern is used all over meta-arm/meta-arm-bsp, I see what you are
> saying, that: require "" throws a bitbake error. But I guess that every
> machine needs a require for specifying optee_os platform configuration
> and details.
>
I think the issue is because now with the optee-os_3.20 bbappend the n1sdp
and the tc override don't apply
so the MACHINE_OPTEE_OS_REQUIRE can be blank which will trigger the parsing
error.
Jose
>
> @Ross, @Jon am I missing something here?
>
> Cheers,
> Rui
> >
> >
> >> --
> >> 2.34.1
> >>
> >>
> >> -=-=-=-=-=-=-=-=-=-=-=-
> >> Links: You receive all messages sent to this group.
> >> View/Reply Online (#4506):
> >> https://lists.yoctoproject.org/g/meta-arm/message/4506
> >> Mute This Topic: https://lists.yoctoproject.org/mt/97932156/5052612
> >> Group Owner: meta-arm+owner@lists.yoctoproject.org
> >> Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub [
> >> quaresma.jose@gmail.com]
> >> -=-=-=-=-=-=-=-=-=-=-=-
> >>
> >>
> >
> > --
> > Best regards,
> >
> > José Quaresma
>
--
Best regards,
José Quaresma
[-- Attachment #2: Type: text/html, Size: 10380 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-arm] [PATCH] arm-bsp/optee: bump corstone1000 to v3.20
2023-03-30 6:41 ` [meta-arm] " Jose Quaresma
@ 2023-03-30 7:14 ` Rui Miguel Silva
2023-03-30 7:38 ` Jose Quaresma
0 siblings, 1 reply; 6+ messages in thread
From: Rui Miguel Silva @ 2023-03-30 7:14 UTC (permalink / raw)
To: Jose Quaresma, meta-arm
Hi Jose,
Jose Quaresma <quaresma.jose@gmail.com> writes:
> Hi,
>
> Reply directly to Rui but not for the mailing list so forward it.
Sorry about that.
>
> Rui Miguel Silva <rui.silva@linaro.org> escreveu no dia quarta, 29/03/2023
> à(s) 20:15:
>
>> Oi Jose,
>>
>> Thanks for the review.
>>
>> Jose Quaresma <quaresma.jose@gmail.com> writes:
>>
>> > Hi Rui,
>> >
>> > Rui Miguel Silva <rui.silva@linaro.org> escreveu no dia quarta,
>> 29/03/2023
>> > à(s) 17:15:
>> >
>> >> Bump the preferred corstone1000 to v3.20, drop patch
>> >> that is already included in this version.
>> >> Create the 3.20 bbappend and remove the entry in 3.18 bbappend.
>> >>
>> >> Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
>> >> ---
>> >> .../conf/machine/include/corstone1000.inc | 2 +-
>> >> .../0004-Handle-logging-syscall.patch | 33 -------------------
>> >> .../optee/optee-os-corstone1000-common.inc | 8 -----
>> >> .../optee/optee-os_3.18.0.bbappend | 1 -
>> >> .../optee/optee-os_3.20.0.bbappend | 6 ++++
>> >> 5 files changed, 7 insertions(+), 43 deletions(-)
>> >> delete mode 100644
>> >>
>> meta-arm-bsp/recipes-security/optee/files/optee-os/corstone1000/0004-Handle-logging-syscall.patch
>> >> create mode 100644
>> >> meta-arm-bsp/recipes-security/optee/optee-os_3.20.0.bbappend
>> >>
>> >> diff --git a/meta-arm-bsp/conf/machine/include/corstone1000.inc
>> >> b/meta-arm-bsp/conf/machine/include/corstone1000.inc
>> >> index 7f25cd54455f..3915d18b5627 100644
>> >> --- a/meta-arm-bsp/conf/machine/include/corstone1000.inc
>> >> +++ b/meta-arm-bsp/conf/machine/include/corstone1000.inc
>> >> @@ -34,7 +34,7 @@ UBOOT_ARCH = "arm"
>> >> UBOOT_EXTLINUX = "0"
>> >>
>> >> #optee
>> >> -PREFERRED_VERSION_optee-os ?= "3.18.%"
>> >> +PREFERRED_VERSION_optee-os ?= "3.20.%"
>> >> PREFERRED_VERSION_optee-client ?= "3.18.%"
>> >> EXTRA_IMAGEDEPENDS += "optee-os"
>> >> OPTEE_ARCH = "arm64"
>> >> diff --git
>> >>
>> a/meta-arm-bsp/recipes-security/optee/files/optee-os/corstone1000/0004-Handle-logging-syscall.patch
>> >>
>> b/meta-arm-bsp/recipes-security/optee/files/optee-os/corstone1000/0004-Handle-logging-syscall.patch
>> >> deleted file mode 100644
>> >> index 356be9e04f9e..000000000000
>> >> ---
>> >>
>> a/meta-arm-bsp/recipes-security/optee/files/optee-os/corstone1000/0004-Handle-logging-syscall.patch
>> >> +++ /dev/null
>> >> @@ -1,33 +0,0 @@
>> >> -Upstream-Status: Pending [Not submitted to upstream yet]
>> >> -Signed-off-by: Vishnu Banavath <vishnu.banavath@arm.com>
>> >> -
>> >> -From b3fde6c2e1a950214f760ab9f194f3a6572292a8 Mon Sep 17 00:00:00 2001
>> >> -From: Balint Dobszay <balint.dobszay@arm.com>
>> >> -Date: Fri, 15 Jul 2022 13:45:54 +0200
>> >> -Subject: [PATCH] Handle logging syscall
>> >> -
>> >> -Signed-off-by: Balint Dobszay <balint.dobszay@arm.com>
>> >> -Change-Id: Ib8151cc9c66aea8bcc8fe8b1ecdc3f9f9c5f14e4
>> >> -
>> >> -%% original patch: 0004-Handle-logging-syscall.patch
>> >> -
>> >> -diff --git a/core/arch/arm/kernel/spmc_sp_handler.c
>> >> b/core/arch/arm/kernel/spmc_sp_handler.c
>> >> -index e0fa0aa6..c7a45387 100644
>> >> ---- a/core/arch/arm/kernel/spmc_sp_handler.c
>> >> -+++ b/core/arch/arm/kernel/spmc_sp_handler.c
>> >> -@@ -1004,6 +1004,12 @@ void spmc_sp_msg_handler(struct thread_smc_args
>> >> *args,
>> >> - ffa_mem_reclaim(args, caller_sp);
>> >> - sp_enter(args, caller_sp);
>> >> - break;
>> >> -+ case 0xdeadbeef:
>> >> -+ ts_push_current_session(&caller_sp->ts_sess);
>> >> -+ IMSG("%s", (char *)args->a1);
>> >> -+ ts_pop_current_session();
>> >> -+ sp_enter(args, caller_sp);
>> >> -+ break;
>> >> - default:
>> >> - EMSG("Unhandled FFA function ID %#"PRIx32,
>> >> - (uint32_t)args->a0);
>> >> ---
>> >> -2.17.1
>> >> -
>> >> diff --git
>> >> a/meta-arm-bsp/recipes-security/optee/optee-os-corstone1000-common.inc
>> >> b/meta-arm-bsp/recipes-security/optee/optee-os-corstone1000-common.inc
>> >> index 71b5ee62b902..30f99666626c 100644
>> >> ---
>> a/meta-arm-bsp/recipes-security/optee/optee-os-corstone1000-common.inc
>> >> +++
>> b/meta-arm-bsp/recipes-security/optee/optee-os-corstone1000-common.inc
>> >> @@ -1,15 +1,7 @@
>> >> -SRCREV = "42f6617108fa43712652ef52f9d5b4ec5b2665f8"
>> >> -PV = "3.18.0+git${SRCPV}"
>> >> -
>> >> SRC_URI:remove = " \
>> >> file://0003-core-link-add-no-warn-rwx-segments.patch
>> \
>> >> "
>> >>
>> >> -FILESEXTRAPATHS:prepend := "${THISDIR}/files/optee-os/corstone1000:"
>> >> -SRC_URI:append = " \
>> >> - file://0004-Handle-logging-syscall.patch \
>> >> - "
>> >> -
>> >> COMPATIBLE_MACHINE = "corstone1000"
>> >>
>> >> OPTEEMACHINE = "corstone1000"
>> >> diff --git
>> a/meta-arm-bsp/recipes-security/optee/optee-os_3.18.0.bbappend
>> >> b/meta-arm-bsp/recipes-security/optee/optee-os_3.18.0.bbappend
>> >> index 4b03985ac97a..bc933dd54c48 100644
>> >> --- a/meta-arm-bsp/recipes-security/optee/optee-os_3.18.0.bbappend
>> >> +++ b/meta-arm-bsp/recipes-security/optee/optee-os_3.18.0.bbappend
>> >> @@ -3,6 +3,5 @@
>> >> MACHINE_OPTEE_OS_REQUIRE ?= ""
>> >> MACHINE_OPTEE_OS_REQUIRE:n1sdp = "optee-os-n1sdp.inc"
>> >> MACHINE_OPTEE_OS_REQUIRE:tc = "optee-os-tc.inc"
>> >> -MACHINE_OPTEE_OS_REQUIRE:corstone1000 =
>> "optee-os-corstone1000-common.inc"
>> >>
>> >> require ${MACHINE_OPTEE_OS_REQUIRE}
>> >> diff --git
>> a/meta-arm-bsp/recipes-security/optee/optee-os_3.20.0.bbappend
>> >> b/meta-arm-bsp/recipes-security/optee/optee-os_3.20.0.bbappend
>> >> new file mode 100644
>> >> index 000000000000..e732c80f880b
>> >> --- /dev/null
>> >> +++ b/meta-arm-bsp/recipes-security/optee/optee-os_3.20.0.bbappend
>> >> @@ -0,0 +1,6 @@
>> >> +# Machine specific configurations
>> >> +
>> >> +MACHINE_OPTEE_OS_REQUIRE ?= ""
>> >> +MACHINE_OPTEE_OS_REQUIRE:corstone1000 =
>> "optee-os-corstone1000-common.inc"
>> >> +
>> >> +require ${MACHINE_OPTEE_OS_REQUIRE}
>> >>
>> >
>> > This will generate a bitbake parse error for other machines than
>> > corstone1000.
>> >
>> > Jose
>>
>> This pattern is used all over meta-arm/meta-arm-bsp, I see what you are
>> saying, that: require "" throws a bitbake error. But I guess that every
>> machine needs a require for specifying optee_os platform configuration
>> and details.
>>
>
> I think the issue is because now with the optee-os_3.20 bbappend the n1sdp
> and the tc override don't apply
> so the MACHINE_OPTEE_OS_REQUIRE can be blank which will trigger the parsing
> error.
But doesn't n1sdp and tc use the 3.18 bbappend? Here in the CI it is not
failing to build for that platforms.
Cheers,
Rui
>
> Jose
>
>
>>
>> @Ross, @Jon am I missing something here?
>>
>> Cheers,
>> Rui
>> >
>> >
>> >> --
>> >> 2.34.1
>> >>
>> >>
>> >> -=-=-=-=-=-=-=-=-=-=-=-
>> >> Links: You receive all messages sent to this group.
>> >> View/Reply Online (#4506):
>> >> https://lists.yoctoproject.org/g/meta-arm/message/4506
>> >> Mute This Topic: https://lists.yoctoproject.org/mt/97932156/5052612
>> >> Group Owner: meta-arm+owner@lists.yoctoproject.org
>> >> Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub [
>> >> quaresma.jose@gmail.com]
>> >> -=-=-=-=-=-=-=-=-=-=-=-
>> >>
>> >>
>> >
>> > --
>> > Best regards,
>> >
>> > José Quaresma
>>
>
>
> --
> Best regards,
>
> José Quaresma
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-arm] [PATCH] arm-bsp/optee: bump corstone1000 to v3.20
2023-03-30 7:14 ` Rui Miguel Silva
@ 2023-03-30 7:38 ` Jose Quaresma
2023-03-30 8:21 ` Rui Silva
0 siblings, 1 reply; 6+ messages in thread
From: Jose Quaresma @ 2023-03-30 7:38 UTC (permalink / raw)
To: Rui Miguel Silva; +Cc: meta-arm
[-- Attachment #1: Type: text/plain, Size: 8690 bytes --]
Rui Miguel Silva <rui.silva@linaro.org> escreveu no dia quinta, 30/03/2023
à(s) 08:15:
> Hi Jose,
>
> Jose Quaresma <quaresma.jose@gmail.com> writes:
>
> > Hi,
> >
> > Reply directly to Rui but not for the mailing list so forward it.
>
> Sorry about that.
>
no problem! I was the one who forgot to forward to the mailing list.
>
> >
> > Rui Miguel Silva <rui.silva@linaro.org> escreveu no dia quarta,
> 29/03/2023
> > à(s) 20:15:
> >
> >> Oi Jose,
> >>
> >> Thanks for the review.
> >>
> >> Jose Quaresma <quaresma.jose@gmail.com> writes:
> >>
> >> > Hi Rui,
> >> >
> >> > Rui Miguel Silva <rui.silva@linaro.org> escreveu no dia quarta,
> >> 29/03/2023
> >> > à(s) 17:15:
> >> >
> >> >> Bump the preferred corstone1000 to v3.20, drop patch
> >> >> that is already included in this version.
> >> >> Create the 3.20 bbappend and remove the entry in 3.18 bbappend.
> >> >>
> >> >> Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
> >> >> ---
> >> >> .../conf/machine/include/corstone1000.inc | 2 +-
> >> >> .../0004-Handle-logging-syscall.patch | 33
> -------------------
> >> >> .../optee/optee-os-corstone1000-common.inc | 8 -----
> >> >> .../optee/optee-os_3.18.0.bbappend | 1 -
> >> >> .../optee/optee-os_3.20.0.bbappend | 6 ++++
> >> >> 5 files changed, 7 insertions(+), 43 deletions(-)
> >> >> delete mode 100644
> >> >>
> >>
> meta-arm-bsp/recipes-security/optee/files/optee-os/corstone1000/0004-Handle-logging-syscall.patch
> >> >> create mode 100644
> >> >> meta-arm-bsp/recipes-security/optee/optee-os_3.20.0.bbappend
> >> >>
> >> >> diff --git a/meta-arm-bsp/conf/machine/include/corstone1000.inc
> >> >> b/meta-arm-bsp/conf/machine/include/corstone1000.inc
> >> >> index 7f25cd54455f..3915d18b5627 100644
> >> >> --- a/meta-arm-bsp/conf/machine/include/corstone1000.inc
> >> >> +++ b/meta-arm-bsp/conf/machine/include/corstone1000.inc
> >> >> @@ -34,7 +34,7 @@ UBOOT_ARCH = "arm"
> >> >> UBOOT_EXTLINUX = "0"
> >> >>
> >> >> #optee
> >> >> -PREFERRED_VERSION_optee-os ?= "3.18.%"
> >> >> +PREFERRED_VERSION_optee-os ?= "3.20.%"
> >> >> PREFERRED_VERSION_optee-client ?= "3.18.%"
> >> >> EXTRA_IMAGEDEPENDS += "optee-os"
> >> >> OPTEE_ARCH = "arm64"
> >> >> diff --git
> >> >>
> >>
> a/meta-arm-bsp/recipes-security/optee/files/optee-os/corstone1000/0004-Handle-logging-syscall.patch
> >> >>
> >>
> b/meta-arm-bsp/recipes-security/optee/files/optee-os/corstone1000/0004-Handle-logging-syscall.patch
> >> >> deleted file mode 100644
> >> >> index 356be9e04f9e..000000000000
> >> >> ---
> >> >>
> >>
> a/meta-arm-bsp/recipes-security/optee/files/optee-os/corstone1000/0004-Handle-logging-syscall.patch
> >> >> +++ /dev/null
> >> >> @@ -1,33 +0,0 @@
> >> >> -Upstream-Status: Pending [Not submitted to upstream yet]
> >> >> -Signed-off-by: Vishnu Banavath <vishnu.banavath@arm.com>
> >> >> -
> >> >> -From b3fde6c2e1a950214f760ab9f194f3a6572292a8 Mon Sep 17 00:00:00
> 2001
> >> >> -From: Balint Dobszay <balint.dobszay@arm.com>
> >> >> -Date: Fri, 15 Jul 2022 13:45:54 +0200
> >> >> -Subject: [PATCH] Handle logging syscall
> >> >> -
> >> >> -Signed-off-by: Balint Dobszay <balint.dobszay@arm.com>
> >> >> -Change-Id: Ib8151cc9c66aea8bcc8fe8b1ecdc3f9f9c5f14e4
> >> >> -
> >> >> -%% original patch: 0004-Handle-logging-syscall.patch
> >> >> -
> >> >> -diff --git a/core/arch/arm/kernel/spmc_sp_handler.c
> >> >> b/core/arch/arm/kernel/spmc_sp_handler.c
> >> >> -index e0fa0aa6..c7a45387 100644
> >> >> ---- a/core/arch/arm/kernel/spmc_sp_handler.c
> >> >> -+++ b/core/arch/arm/kernel/spmc_sp_handler.c
> >> >> -@@ -1004,6 +1004,12 @@ void spmc_sp_msg_handler(struct
> thread_smc_args
> >> >> *args,
> >> >> - ffa_mem_reclaim(args, caller_sp);
> >> >> - sp_enter(args, caller_sp);
> >> >> - break;
> >> >> -+ case 0xdeadbeef:
> >> >> -+ ts_push_current_session(&caller_sp->ts_sess);
> >> >> -+ IMSG("%s", (char *)args->a1);
> >> >> -+ ts_pop_current_session();
> >> >> -+ sp_enter(args, caller_sp);
> >> >> -+ break;
> >> >> - default:
> >> >> - EMSG("Unhandled FFA function ID %#"PRIx32,
> >> >> - (uint32_t)args->a0);
> >> >> ---
> >> >> -2.17.1
> >> >> -
> >> >> diff --git
> >> >>
> a/meta-arm-bsp/recipes-security/optee/optee-os-corstone1000-common.inc
> >> >>
> b/meta-arm-bsp/recipes-security/optee/optee-os-corstone1000-common.inc
> >> >> index 71b5ee62b902..30f99666626c 100644
> >> >> ---
> >> a/meta-arm-bsp/recipes-security/optee/optee-os-corstone1000-common.inc
> >> >> +++
> >> b/meta-arm-bsp/recipes-security/optee/optee-os-corstone1000-common.inc
> >> >> @@ -1,15 +1,7 @@
> >> >> -SRCREV = "42f6617108fa43712652ef52f9d5b4ec5b2665f8"
> >> >> -PV = "3.18.0+git${SRCPV}"
> >> >> -
> >> >> SRC_URI:remove = " \
> >> >>
> file://0003-core-link-add-no-warn-rwx-segments.patch
> >> \
> >> >> "
> >> >>
> >> >> -FILESEXTRAPATHS:prepend := "${THISDIR}/files/optee-os/corstone1000:"
> >> >> -SRC_URI:append = " \
> >> >> - file://0004-Handle-logging-syscall.patch \
> >> >> - "
> >> >> -
> >> >> COMPATIBLE_MACHINE = "corstone1000"
> >> >>
> >> >> OPTEEMACHINE = "corstone1000"
> >> >> diff --git
> >> a/meta-arm-bsp/recipes-security/optee/optee-os_3.18.0.bbappend
> >> >> b/meta-arm-bsp/recipes-security/optee/optee-os_3.18.0.bbappend
> >> >> index 4b03985ac97a..bc933dd54c48 100644
> >> >> --- a/meta-arm-bsp/recipes-security/optee/optee-os_3.18.0.bbappend
> >> >> +++ b/meta-arm-bsp/recipes-security/optee/optee-os_3.18.0.bbappend
> >> >> @@ -3,6 +3,5 @@
> >> >> MACHINE_OPTEE_OS_REQUIRE ?= ""
> >> >> MACHINE_OPTEE_OS_REQUIRE:n1sdp = "optee-os-n1sdp.inc"
> >> >> MACHINE_OPTEE_OS_REQUIRE:tc = "optee-os-tc.inc"
> >> >> -MACHINE_OPTEE_OS_REQUIRE:corstone1000 =
> >> "optee-os-corstone1000-common.inc"
> >> >>
> >> >> require ${MACHINE_OPTEE_OS_REQUIRE}
> >> >> diff --git
> >> a/meta-arm-bsp/recipes-security/optee/optee-os_3.20.0.bbappend
> >> >> b/meta-arm-bsp/recipes-security/optee/optee-os_3.20.0.bbappend
> >> >> new file mode 100644
> >> >> index 000000000000..e732c80f880b
> >> >> --- /dev/null
> >> >> +++ b/meta-arm-bsp/recipes-security/optee/optee-os_3.20.0.bbappend
> >> >> @@ -0,0 +1,6 @@
> >> >> +# Machine specific configurations
> >> >> +
> >> >> +MACHINE_OPTEE_OS_REQUIRE ?= ""
> >> >> +MACHINE_OPTEE_OS_REQUIRE:corstone1000 =
> >> "optee-os-corstone1000-common.inc"
> >> >> +
> >> >> +require ${MACHINE_OPTEE_OS_REQUIRE}
> >> >>
> >> >
> >> > This will generate a bitbake parse error for other machines than
> >> > corstone1000.
> >> >
> >> > Jose
> >>
> >> This pattern is used all over meta-arm/meta-arm-bsp, I see what you are
> >> saying, that: require "" throws a bitbake error. But I guess that every
> >> machine needs a require for specifying optee_os platform configuration
> >> and details.
> >>
> >
> > I think the issue is because now with the optee-os_3.20 bbappend the
> n1sdp
> > and the tc override don't apply
> > so the MACHINE_OPTEE_OS_REQUIRE can be blank which will trigger the
> parsing
> > error.
>
> But doesn't n1sdp and tc use the 3.18 bbappend? Here in the CI it is not
> failing to build for that platforms.
>
I have misunderstood that to use the 3.20 bbappend, the machine needs to be
the corstone1000
because of the preferred version in
meta-arm-bsp/conf/machine/include/corstone1000.inc.
So the MACHINE_OPTEE_OS_REQUIRE will never be empty.
Sorry for the noise.
Jose
>
> Cheers,
> Rui
>
> >
> > Jose
> >
> >
> >>
> >> @Ross, @Jon am I missing something here?
> >>
> >> Cheers,
> >> Rui
> >> >
> >> >
> >> >> --
> >> >> 2.34.1
> >> >>
> >> >>
> >> >> -=-=-=-=-=-=-=-=-=-=-=-
> >> >> Links: You receive all messages sent to this group.
> >> >> View/Reply Online (#4506):
> >> >> https://lists.yoctoproject.org/g/meta-arm/message/4506
> >> >> Mute This Topic: https://lists.yoctoproject.org/mt/97932156/5052612
> >> >> Group Owner: meta-arm+owner@lists.yoctoproject.org
> >> >> Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub [
> >> >> quaresma.jose@gmail.com]
> >> >> -=-=-=-=-=-=-=-=-=-=-=-
> >> >>
> >> >>
> >> >
> >> > --
> >> > Best regards,
> >> >
> >> > José Quaresma
> >>
> >
> >
> > --
> > Best regards,
> >
> > José Quaresma
>
--
Best regards,
José Quaresma
[-- Attachment #2: Type: text/html, Size: 13643 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-arm] [PATCH] arm-bsp/optee: bump corstone1000 to v3.20
2023-03-30 7:38 ` Jose Quaresma
@ 2023-03-30 8:21 ` Rui Silva
0 siblings, 0 replies; 6+ messages in thread
From: Rui Silva @ 2023-03-30 8:21 UTC (permalink / raw)
To: Jose Quaresma; +Cc: meta-arm
[-- Attachment #1: Type: text/plain, Size: 9154 bytes --]
Hi José,
On Thu, 30 Mar 2023, 08:38 Jose Quaresma, <quaresma.jose@gmail.com> wrote:
>
>
> Rui Miguel Silva <rui.silva@linaro.org> escreveu no dia quinta,
> 30/03/2023 à(s) 08:15:
>
>> Hi Jose,
>>
>> Jose Quaresma <quaresma.jose@gmail.com> writes:
>>
>> > Hi,
>> >
>> > Reply directly to Rui but not for the mailing list so forward it.
>>
>> Sorry about that.
>>
>
> no problem! I was the one who forgot to forward to the mailing list.
>
>
>>
>> >
>> > Rui Miguel Silva <rui.silva@linaro.org> escreveu no dia quarta,
>> 29/03/2023
>> > à(s) 20:15:
>> >
>> >> Oi Jose,
>> >>
>> >> Thanks for the review.
>> >>
>> >> Jose Quaresma <quaresma.jose@gmail.com> writes:
>> >>
>> >> > Hi Rui,
>> >> >
>> >> > Rui Miguel Silva <rui.silva@linaro.org> escreveu no dia quarta,
>> >> 29/03/2023
>> >> > à(s) 17:15:
>> >> >
>> >> >> Bump the preferred corstone1000 to v3.20, drop patch
>> >> >> that is already included in this version.
>> >> >> Create the 3.20 bbappend and remove the entry in 3.18 bbappend.
>> >> >>
>> >> >> Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
>> >> >> ---
>> >> >> .../conf/machine/include/corstone1000.inc | 2 +-
>> >> >> .../0004-Handle-logging-syscall.patch | 33
>> -------------------
>> >> >> .../optee/optee-os-corstone1000-common.inc | 8 -----
>> >> >> .../optee/optee-os_3.18.0.bbappend | 1 -
>> >> >> .../optee/optee-os_3.20.0.bbappend | 6 ++++
>> >> >> 5 files changed, 7 insertions(+), 43 deletions(-)
>> >> >> delete mode 100644
>> >> >>
>> >>
>> meta-arm-bsp/recipes-security/optee/files/optee-os/corstone1000/0004-Handle-logging-syscall.patch
>> >> >> create mode 100644
>> >> >> meta-arm-bsp/recipes-security/optee/optee-os_3.20.0.bbappend
>> >> >>
>> >> >> diff --git a/meta-arm-bsp/conf/machine/include/corstone1000.inc
>> >> >> b/meta-arm-bsp/conf/machine/include/corstone1000.inc
>> >> >> index 7f25cd54455f..3915d18b5627 100644
>> >> >> --- a/meta-arm-bsp/conf/machine/include/corstone1000.inc
>> >> >> +++ b/meta-arm-bsp/conf/machine/include/corstone1000.inc
>> >> >> @@ -34,7 +34,7 @@ UBOOT_ARCH = "arm"
>> >> >> UBOOT_EXTLINUX = "0"
>> >> >>
>> >> >> #optee
>> >> >> -PREFERRED_VERSION_optee-os ?= "3.18.%"
>> >> >> +PREFERRED_VERSION_optee-os ?= "3.20.%"
>> >> >> PREFERRED_VERSION_optee-client ?= "3.18.%"
>> >> >> EXTRA_IMAGEDEPENDS += "optee-os"
>> >> >> OPTEE_ARCH = "arm64"
>> >> >> diff --git
>> >> >>
>> >>
>> a/meta-arm-bsp/recipes-security/optee/files/optee-os/corstone1000/0004-Handle-logging-syscall.patch
>> >> >>
>> >>
>> b/meta-arm-bsp/recipes-security/optee/files/optee-os/corstone1000/0004-Handle-logging-syscall.patch
>> >> >> deleted file mode 100644
>> >> >> index 356be9e04f9e..000000000000
>> >> >> ---
>> >> >>
>> >>
>> a/meta-arm-bsp/recipes-security/optee/files/optee-os/corstone1000/0004-Handle-logging-syscall.patch
>> >> >> +++ /dev/null
>> >> >> @@ -1,33 +0,0 @@
>> >> >> -Upstream-Status: Pending [Not submitted to upstream yet]
>> >> >> -Signed-off-by: Vishnu Banavath <vishnu.banavath@arm.com>
>> >> >> -
>> >> >> -From b3fde6c2e1a950214f760ab9f194f3a6572292a8 Mon Sep 17 00:00:00
>> 2001
>> >> >> -From: Balint Dobszay <balint.dobszay@arm.com>
>> >> >> -Date: Fri, 15 Jul 2022 13:45:54 +0200
>> >> >> -Subject: [PATCH] Handle logging syscall
>> >> >> -
>> >> >> -Signed-off-by: Balint Dobszay <balint.dobszay@arm.com>
>> >> >> -Change-Id: Ib8151cc9c66aea8bcc8fe8b1ecdc3f9f9c5f14e4
>> >> >> -
>> >> >> -%% original patch: 0004-Handle-logging-syscall.patch
>> >> >> -
>> >> >> -diff --git a/core/arch/arm/kernel/spmc_sp_handler.c
>> >> >> b/core/arch/arm/kernel/spmc_sp_handler.c
>> >> >> -index e0fa0aa6..c7a45387 100644
>> >> >> ---- a/core/arch/arm/kernel/spmc_sp_handler.c
>> >> >> -+++ b/core/arch/arm/kernel/spmc_sp_handler.c
>> >> >> -@@ -1004,6 +1004,12 @@ void spmc_sp_msg_handler(struct
>> thread_smc_args
>> >> >> *args,
>> >> >> - ffa_mem_reclaim(args, caller_sp);
>> >> >> - sp_enter(args, caller_sp);
>> >> >> - break;
>> >> >> -+ case 0xdeadbeef:
>> >> >> -+
>> ts_push_current_session(&caller_sp->ts_sess);
>> >> >> -+ IMSG("%s", (char *)args->a1);
>> >> >> -+ ts_pop_current_session();
>> >> >> -+ sp_enter(args, caller_sp);
>> >> >> -+ break;
>> >> >> - default:
>> >> >> - EMSG("Unhandled FFA function ID %#"PRIx32,
>> >> >> - (uint32_t)args->a0);
>> >> >> ---
>> >> >> -2.17.1
>> >> >> -
>> >> >> diff --git
>> >> >>
>> a/meta-arm-bsp/recipes-security/optee/optee-os-corstone1000-common.inc
>> >> >>
>> b/meta-arm-bsp/recipes-security/optee/optee-os-corstone1000-common.inc
>> >> >> index 71b5ee62b902..30f99666626c 100644
>> >> >> ---
>> >> a/meta-arm-bsp/recipes-security/optee/optee-os-corstone1000-common.inc
>> >> >> +++
>> >> b/meta-arm-bsp/recipes-security/optee/optee-os-corstone1000-common.inc
>> >> >> @@ -1,15 +1,7 @@
>> >> >> -SRCREV = "42f6617108fa43712652ef52f9d5b4ec5b2665f8"
>> >> >> -PV = "3.18.0+git${SRCPV}"
>> >> >> -
>> >> >> SRC_URI:remove = " \
>> >> >>
>> file://0003-core-link-add-no-warn-rwx-segments.patch
>> >> \
>> >> >> "
>> >> >>
>> >> >> -FILESEXTRAPATHS:prepend :=
>> "${THISDIR}/files/optee-os/corstone1000:"
>> >> >> -SRC_URI:append = " \
>> >> >> - file://0004-Handle-logging-syscall.patch \
>> >> >> - "
>> >> >> -
>> >> >> COMPATIBLE_MACHINE = "corstone1000"
>> >> >>
>> >> >> OPTEEMACHINE = "corstone1000"
>> >> >> diff --git
>> >> a/meta-arm-bsp/recipes-security/optee/optee-os_3.18.0.bbappend
>> >> >> b/meta-arm-bsp/recipes-security/optee/optee-os_3.18.0.bbappend
>> >> >> index 4b03985ac97a..bc933dd54c48 100644
>> >> >> --- a/meta-arm-bsp/recipes-security/optee/optee-os_3.18.0.bbappend
>> >> >> +++ b/meta-arm-bsp/recipes-security/optee/optee-os_3.18.0.bbappend
>> >> >> @@ -3,6 +3,5 @@
>> >> >> MACHINE_OPTEE_OS_REQUIRE ?= ""
>> >> >> MACHINE_OPTEE_OS_REQUIRE:n1sdp = "optee-os-n1sdp.inc"
>> >> >> MACHINE_OPTEE_OS_REQUIRE:tc = "optee-os-tc.inc"
>> >> >> -MACHINE_OPTEE_OS_REQUIRE:corstone1000 =
>> >> "optee-os-corstone1000-common.inc"
>> >> >>
>> >> >> require ${MACHINE_OPTEE_OS_REQUIRE}
>> >> >> diff --git
>> >> a/meta-arm-bsp/recipes-security/optee/optee-os_3.20.0.bbappend
>> >> >> b/meta-arm-bsp/recipes-security/optee/optee-os_3.20.0.bbappend
>> >> >> new file mode 100644
>> >> >> index 000000000000..e732c80f880b
>> >> >> --- /dev/null
>> >> >> +++ b/meta-arm-bsp/recipes-security/optee/optee-os_3.20.0.bbappend
>> >> >> @@ -0,0 +1,6 @@
>> >> >> +# Machine specific configurations
>> >> >> +
>> >> >> +MACHINE_OPTEE_OS_REQUIRE ?= ""
>> >> >> +MACHINE_OPTEE_OS_REQUIRE:corstone1000 =
>> >> "optee-os-corstone1000-common.inc"
>> >> >> +
>> >> >> +require ${MACHINE_OPTEE_OS_REQUIRE}
>> >> >>
>> >> >
>> >> > This will generate a bitbake parse error for other machines than
>> >> > corstone1000.
>> >> >
>> >> > Jose
>> >>
>> >> This pattern is used all over meta-arm/meta-arm-bsp, I see what you are
>> >> saying, that: require "" throws a bitbake error. But I guess that every
>> >> machine needs a require for specifying optee_os platform configuration
>> >> and details.
>> >>
>> >
>> > I think the issue is because now with the optee-os_3.20 bbappend the
>> n1sdp
>> > and the tc override don't apply
>> > so the MACHINE_OPTEE_OS_REQUIRE can be blank which will trigger the
>> parsing
>> > error.
>>
>> But doesn't n1sdp and tc use the 3.18 bbappend? Here in the CI it is not
>> failing to build for that platforms.
>>
>
> I have misunderstood that to use the 3.20 bbappend, the machine needs to
> be the corstone1000
> because of the preferred version in
> meta-arm-bsp/conf/machine/include/corstone1000.inc.
> So the MACHINE_OPTEE_OS_REQUIRE will never be empty.
>
> Sorry for the noise.
>
Yes that is indeed needed. No problem at all.
And appreciated for the review.
Cheers,
Rui
Jose
>
>
>>
>> Cheers,
>> Rui
>>
>> >
>> > Jose
>> >
>> >
>> >>
>> >> @Ross, @Jon am I missing something here?
>> >>
>> >> Cheers,
>> >> Rui
>> >> >
>> >> >
>> >> >> --
>> >> >> 2.34.1
>> >> >>
>> >> >>
>> >> >> -=-=-=-=-=-=-=-=-=-=-=-
>> >> >> Links: You receive all messages sent to this group.
>> >> >> View/Reply Online (#4506):
>> >> >> https://lists.yoctoproject.org/g/meta-arm/message/4506
>> >> >> Mute This Topic: https://lists.yoctoproject.org/mt/97932156/5052612
>> >> >> Group Owner: meta-arm+owner@lists.yoctoproject.org
>> >> >> Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub [
>> >> >> quaresma.jose@gmail.com]
>> >> >> -=-=-=-=-=-=-=-=-=-=-=-
>> >> >>
>> >> >>
>> >> >
>> >> > --
>> >> > Best regards,
>> >> >
>> >> > José Quaresma
>> >>
>> >
>> >
>> > --
>> > Best regards,
>> >
>> > José Quaresma
>>
>
>
> --
> Best regards,
>
> José Quaresma
>
[-- Attachment #2: Type: text/html, Size: 14668 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm-bsp/optee: bump corstone1000 to v3.20
2023-03-29 16:16 [PATCH] arm-bsp/optee: bump corstone1000 to v3.20 Rui Miguel Silva
[not found] ` <CANPvuR=mFEJ-03fo5JZcW-+oyKH5i+hzf+Jm4E3r37uxeRRgTQ@mail.gmail.com>
@ 2023-03-30 23:17 ` Jon Mason
1 sibling, 0 replies; 6+ messages in thread
From: Jon Mason @ 2023-03-30 23:17 UTC (permalink / raw)
To: meta-arm, Rui Miguel Silva
On Wed, 29 Mar 2023 17:16:13 +0100, Rui Miguel Silva wrote:
> Bump the preferred corstone1000 to v3.20, drop patch
> that is already included in this version.
> Create the 3.20 bbappend and remove the entry in 3.18 bbappend.
Applied, thanks!
[1/1] arm-bsp/optee: bump corstone1000 to v3.20
commit: df726cbfad017c78f0b7d6687aa37b5d3c0b2e99
Best regards,
--
Jon Mason <jon.mason@arm.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-03-31 2:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-29 16:16 [PATCH] arm-bsp/optee: bump corstone1000 to v3.20 Rui Miguel Silva
[not found] ` <CANPvuR=mFEJ-03fo5JZcW-+oyKH5i+hzf+Jm4E3r37uxeRRgTQ@mail.gmail.com>
[not found] ` <m31ql7xtb2.fsf@gmail.com>
2023-03-30 6:41 ` [meta-arm] " Jose Quaresma
2023-03-30 7:14 ` Rui Miguel Silva
2023-03-30 7:38 ` Jose Quaresma
2023-03-30 8:21 ` Rui Silva
2023-03-30 23:17 ` Jon Mason
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.