From: Chris Ball <cjb@laptop.org>
To: Mikko Vinni <mmvinni@yahoo.com>
Cc: Wolfram Sang <w.sang@pengutronix.de>, linux-mmc@vger.kernel.org
Subject: Re: [RFC] mmc: sdhci: work around broken dma boundary behavior
Date: Tue, 12 Apr 2011 13:29:49 -0400 [thread overview]
Message-ID: <m3y63fz8c2.fsf@pullcord.laptop.org> (raw)
In-Reply-To: <1301388814-10931-1-git-send-email-mmvinni@yahoo.com> (Mikko Vinni's message of "Tue, 29 Mar 2011 11:53:34 +0300")
Hi Mikko,
On Tue, Mar 29 2011, Mikko Vinni wrote:
> Some SD host controllers (noticed on an integrated JMicron
> SD reader on an HP Pavilion dv5-1250eo laptop) don't update
> the dma address register before signaling a dma interrupt due
> to a dma boundary. Update the register manually to the next
> boundary (by default 512KiB), at which the transfer stopped.
>
> As long as each transfer is at most 512KiB in size (guaranteed
> by a BUG_ON in sdhci_prepare_data()) and the boundary is kept
> at the default value, this fix is needed at most once per
> transfer. Smaller boundaries are taken care of by counting
> the transferred bytes.
>
> Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=28462
>
> Signed-off-by: Mikko Vinni <mmvinni@yahoo.com>
I know you posted this as an RFC, but I've pushed it to mmc-next for
testing now, and will plan on merging it for .40 if everything goes well.
Thanks very much!
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2011-04-12 17:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-07 20:40 [PATCH resend] sdhci: work around broken dma boundary behaviour Mikko Vinni
2011-03-08 20:12 ` Chris Ball
2011-03-08 22:12 ` Wolfram Sang
2011-03-12 21:43 ` Wolfram Sang
2011-03-14 9:23 ` Mikko Vinni
2011-03-14 10:18 ` Wolfram Sang
2011-03-14 13:00 ` Mikko Vinni
2011-03-14 15:28 ` Wolfram Sang
2011-03-14 15:58 ` Mikko Vinni
2011-03-14 17:21 ` Wolfram Sang
2011-03-29 8:53 ` [RFC] mmc: sdhci: work around broken dma boundary behavior Mikko Vinni
2011-04-11 21:05 ` Chris Ball
2011-04-12 4:56 ` Wolfram Sang
2011-04-12 17:29 ` Chris Ball [this message]
2011-04-13 7:04 ` Mikko Vinni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3y63fz8c2.fsf@pullcord.laptop.org \
--to=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mmvinni@yahoo.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.