From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=50918 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q4AUK-0006oT-0c for qemu-devel@nongnu.org; Mon, 28 Mar 2011 07:20:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q4AUE-0000EF-Ku for qemu-devel@nongnu.org; Mon, 28 Mar 2011 07:19:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60992) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q4AUE-0000DY-0F for qemu-devel@nongnu.org; Mon, 28 Mar 2011 07:19:54 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2SBJqHb012527 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 28 Mar 2011 07:19:52 -0400 From: Juan Quintela In-Reply-To: <20110328024726.4753.77783.stgit@dhcp-91-7.nay.redhat.com.englab.nay.redhat.com> (Jason Wang's message of "Mon, 28 Mar 2011 10:47:27 +0800") References: <20110328024726.4753.77783.stgit@dhcp-91-7.nay.redhat.com.englab.nay.redhat.com> Date: Mon, 28 Mar 2011 13:18:10 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [V2 PATCH] floppy: save and restore DIR register Reply-To: quintela@redhat.com List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org Jason Wang wrote: > We need to keep DIR register unchanged across migration, but currently it > depends on the media_changed flags from block layer. Since we do not > save/restore it and the bdrv_open() called in dest node may set the > media_changed flag when trying to open floppy image, guest driver may think the > floppy have changed after migration. To fix this, a new filed media_changed in > FDrive strcutre was introduced in order to save and restore the it from block > layer through pre_save/post_load callbacks. > > Signed-off-by: Jason Wang Reviewed-by: Juan Quintela