All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: Peter Oberndorfer <kumbayo84@arcor.de>
Cc: "Karl Hasselström" <kha@treskal.com>,
	"Dan McGee" <dpmcgee@gmail.com>,
	git@vger.kernel.org,
	"Catalin Marinas" <catalin.marinas@gmail.com>
Subject: Re: [STGIT PATCH] replace "git repo-config" usage by "git config"
Date: Wed, 16 Jan 2008 13:13:35 -0800 (PST)	[thread overview]
Message-ID: <m3y7aplbie.fsf@roke.D-201> (raw)
In-Reply-To: <200801162158.26450.kumbayo84@arcor.de>

Peter Oberndorfer <kumbayo84@arcor.de> writes:

> "git repo-config" will be removed soon
> 
> Signed-off-by: Peter Oberndorfer <kumbayo84@arcor.de>
> ---
> since i am not good at creating log messages, feel free to change it :-)
> built on top of kha experimental patch
> passes all testcases for me

> @@ -47,7 +47,7 @@ class GitConfig:
>          if self.__cache.has_key(name):
>              return self.__cache[name]
>          try:
> -            value = Run('git', 'repo-config', '--get', name).output_one_line()
> +            value = Run('git', 'config', '--get', name).output_one_line()
>          except RunException:
>              value = self.__defaults.get(name, None)
>          self.__cache[name] = value

Strange that StGIT didn't abstracted out reading git config, like
Git.pm and gitweb.perl did.

BTW. will StGIT be using libgit-thin + PyGit, or is it not ready yet?

-- 
Jakub Narebski
Poland
ShadeHawk on #git

  reply	other threads:[~2008-01-16 21:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-16  3:19 [RFC/PATCH] Remove repo-config Dan McGee
2008-01-16  4:23 ` Junio C Hamano
2008-01-16  4:40   ` Dan McGee
2008-01-16 17:20     ` Junio C Hamano
2008-01-16 20:32       ` Junio C Hamano
2008-01-16 20:13 ` Junio C Hamano
2008-01-16 20:47 ` Peter Oberndorfer
2008-01-16 20:58   ` [STGIT PATCH] replace "git repo-config" usage by "git config" Peter Oberndorfer
2008-01-16 21:13     ` Jakub Narebski [this message]
2008-01-16 21:46       ` Peter Oberndorfer
2008-01-17 17:07       ` Catalin Marinas
2008-01-17 23:49         ` Jakub Narebski
2008-01-17  7:45     ` Karl Hasselström
2008-01-18  4:24       ` Karl Hasselström
2008-01-23 11:35         ` Catalin Marinas
2008-01-23 16:10           ` Karl Hasselström
2008-01-23 16:42             ` Catalin Marinas
2008-01-24  7:01               ` Karl Hasselström
2008-01-24 15:31                 ` Catalin Marinas
2008-01-24 18:08                   ` Karl Hasselström
2008-01-24 18:20                     ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3y7aplbie.fsf@roke.D-201 \
    --to=jnareb@gmail.com \
    --cc=catalin.marinas@gmail.com \
    --cc=dpmcgee@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=kha@treskal.com \
    --cc=kumbayo84@arcor.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.