From: Juan Quintela <quintela@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH v2 1/3] qcow2: Factor next_refcount_table_size out
Date: Tue, 23 Feb 2010 17:00:23 +0100 [thread overview]
Message-ID: <m3zl30ndrc.fsf@trasno.mitica> (raw)
In-Reply-To: <1266939654-26510-2-git-send-email-kwolf@redhat.com> (Kevin Wolf's message of "Tue, 23 Feb 2010 16:40:52 +0100")
Kevin Wolf <kwolf@redhat.com> wrote:
> When the refcount table grows, it doesn't only grow by one entry but reserves
> some space for future refcount blocks. The algorithm to calculate the number of
> entries stays the same with the fixes, so factor it out before replacing the
> rest.
>
> As Juan suggested take the opportunity to simplify the code a bit.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Acked-by: Juan Quintela <quintela@redhat.com>
next prev parent reply other threads:[~2010-02-23 16:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-23 15:40 [Qemu-devel] [PATCH v2 0/3] qcow2: Rewrite alloc_refcount_block Kevin Wolf
2010-02-23 15:40 ` [Qemu-devel] [PATCH v2 1/3] qcow2: Factor next_refcount_table_size out Kevin Wolf
2010-02-23 16:00 ` Juan Quintela [this message]
2010-02-23 15:40 ` [Qemu-devel] [PATCH v2 2/3] qcow2: Rewrite alloc_refcount_block/grow_refcount_table Kevin Wolf
2010-02-23 16:07 ` [Qemu-devel] " Juan Quintela
2010-02-23 15:40 ` [Qemu-devel] [PATCH v2 3/3] qcow2: More checks for qemu-img check Kevin Wolf
2010-02-23 16:03 ` [Qemu-devel] " Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3zl30ndrc.fsf@trasno.mitica \
--to=quintela@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.