From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33331CCA468 for ; Tue, 30 Sep 2025 12:19:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P8QOzJy/AMnFvXnxj2GouZmGhQH22CJxyH0DTBnM9ZE=; b=gLCfA+PmsjjQKO ddQi7lLHH4a9/N7zRJT9RNAFBMtcQkDI7JRVp+xlSvJdCuAhSU37m8wLvV2wJVKa2gHBfbcKZBi6h i9bNJ88SvB7hYeyANwdleekBYTBcDPnS9/cJFURblU2sneVUfkYrb80ReddQZDdei6f51Pcaz30x3 NnKLPviyeZhr/VVy/cBGpOF/ZsTZsVE248Gw91uqvi/OCm47sU0zWB5dJ2pUfcFmtej0l7DVDs3NV c8/BXGboPKSDxKr+kdlzNML0/w4Aqkw1j/N2jhbeC1BuikBIUB553lP6cul40VVbrlBp+iHkaZEWy eHCo8Tj9NUUXPaPgbV0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v3ZKR-00000005EwV-0S6w; Tue, 30 Sep 2025 12:19:35 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1v3ZKP-00000005EwJ-3BGD for linux-mtd@lists.infradead.org; Tue, 30 Sep 2025 12:19:33 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 34B2160296; Tue, 30 Sep 2025 12:19:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0011C4CEF0; Tue, 30 Sep 2025 12:19:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1759234772; bh=K/02sF+wmK8zVvZYoYSnvHtVxTq3OlWrSzPnKA270yo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=DgfOdVsZlwSmJA7IW7k1lnvV4jlq5FSwwBDuzMpIZGBtUdDVSJgTquIthFlGa5Q8U 98BLtzqFOohEkkPbc8+FNu7gjY9gDH91lZ3yY37wiMqeZfQ1FunDIqwYk9aVycgpCQ dXxcDiggi1UD9be3PF1r8wXAh7sugOD+P308J7IUiCylTcWtP1fagJFIAoAuTBVEiU DjsygnIC5ZyklUWrMKJ+lbJToLW3Vi4CVgR6YK7x5n6zedQdHtCfnR97n3qgBYQMFF 1/JRi/+JyjcMRDQmpoKNYfnAxvKTmdlfBPrraklKJNyL2IozHxYiSgCJw1xVbYn8LX py8sii1AYhYAQ== From: Pratyush Yadav To: Cheng Ming Lin Cc: Michael Walle , Tudor Ambarus , Guenter Roeck , Pratyush Yadav , Cheng Ming Lin , miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, alvinzhou@mxic.com.tw, leoyu@mxic.com.tw, Maarten Zanders Subject: Re: [PATCH v2 1/3] mtd: spi-nor: macronix: Drop the redundant flash info fields In-Reply-To: (Cheng Ming Lin's message of "Tue, 30 Sep 2025 15:36:40 +0800") References: <20250407075400.1113177-1-linchengming884@gmail.com> <20250407075400.1113177-2-linchengming884@gmail.com> Date: Tue, 30 Sep 2025 14:19:29 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org T24gVHVlLCBTZXAgMzAgMjAyNSwgQ2hlbmcgTWluZyBMaW4gd3JvdGU6Cgo+IEhpIE1pY2hhZWws Cj4KPiBNaWNoYWVsIFdhbGxlIDxtd2FsbGVAa2VybmVsLm9yZz4g5pa8IDIwMjXlubQ55pyIMjTm l6Ug6YCx5LiJIOS4i+WNiDg6MTHlr6vpgZPvvJoKPj4KPj4gPiBUaGUgcm9vdCBjYXVzZSBvZiB0 aGlzIHByb2JsZW0gbGllcyBpbiB0aGUgZmFpbHVyZSBvZiBwYXJzaW5nIHRoZSBTRkRQCj4+ID4g ZGF0YSBmb3IgdGhlIGZsYXNoLCByYXRoZXIgdGhhbiBhbiBpc3N1ZSB3aXRoIHRoZSBwYXRjaCBp dHNlbGYuIEkgYmVsaWV2ZQo+PiA+IHdlIHNob3VsZCBub3QgcmV2ZXJ0IHRoaXMgcGF0Y2guCj4+ Cj4+IEkgZGlzYWdyZWUuIFRoZXJlIGFyZSBNYWNyb25peCBmbGFzaGVzIHdpdGggdGhhdCBJRCB3 aGljaCBkb2Vzbid0Cj4+IGhhdmUgU0ZEUC4gIEFuZCB0aGlzIHBhdGNoIGlzIGRyb3BwaW5nIHN1 cHBvcnQgZm9yIHRoZW0uIFNlZSBhbHNvCj4+IFsxXS4gTm93IEknbSBub3Qgc3VyZSBpdCBpcyB3 b3J0aCByZXZlcnRpbmcgdGhpcyBjb21taXQuIE5vYm9keSwKPj4gZXhjZXB0IEd1ZW50ZXIgY29t cGxhaW5lZCwgYnV0IG9ubHkgKnNvIGZhciogKGFuZCB0aGF0IHBhdGNoIGlzIGluCj4+IHNpbmNl IDYuMTYpLiBBbnkgb3BpbmlvbnM/CgpXaGVuIEkgcmVhZCB0aGlzIEkgd2FzIGp1c3QgaG9waW5n IG5vIG9uZSBjb21wbGFpbnMgYW5kIHdlIGVuZCB1cCBqdXN0CmRyb3BwaW5nIHN1cHBvcnQgZm9y IHRoZXNlIGZsYXNoZXMgdGhhdCBubyBvbmUgc2VlbXMgdG8gdXNlLi4uCgo+Cj4gSSBhZ3JlZSB3 aXRoIHJldmVydGluZyB0aGlzIHBhdGNoLiBXaGVuIEkgaW5pdGlhbGx5IHZlcmlmaWVkIGl0LCB0 aGUKPiBkZXZpY2VzIEkgaGFkIG9uIGhhbmQgYWxsIHN1cHBvcnRlZCBTRkRQLCBzbyBJIGRpZCBu b3QgY2F0Y2ggdGhpcyBpc3N1ZS4KPiBBZnRlciBjaGVja2luZyBhZ2FpbiwgSSBjb25maXJtIHRo YXQgc29tZSBvbGRlciBmbGFzaGVzIHdpdGhvdXQgU0ZEUCBhcmUKPiBpbmRlZWQgYWZmZWN0ZWQu CgpEbyB5b3Uga25vdyBpZiB0aGVzZSBmbGFzaGVzIGFyZSB1c2VkIGluIGFueSBkZXZpY2VzIHRo YXQgYXJlIGFjdGl2ZWx5CnVzZWQgYW5kIG1haW50YWluZWQ/IElmIHNvLCB3ZSBzaG91bGQgcmV2 ZXJ0LiBJZiBpdCBpcyBsaWtlbHkgdGhleQphcmVuJ3QgYWN0aXZlbHkgdXNlZCwgdGhlbiBtYXli ZSB3ZSBqdXN0IGtlZXAgdGhpbmdzIGFzIHRoZXkgYXJlPwpEdW5uby4uLgoKPgo+IFdvdWxkIGl0 IG1ha2Ugc2Vuc2UgdG8gb25seSBjaGFuZ2UgdGhlIGAubmFtZWAgZmllbGQgdG8gdXNlIGEgY29t bWVudCwKPiB3aGlsZSBrZWVwaW5nIHRoZSByZXN0IGFzIGlzPyBUaGF0IHdheSB3ZSBjYW4gc3Rp bGwgc3VwcG9ydCBmbGFzaGVzIHRoYXQKPiBtYXkgbm90IHByb3ZpZGUgU0ZEUC4KClN1cmUsIHRo YXQgd291bGQgYmUgYSBnb29kIGltcHJvdmVtZW50IG92ZXIgYSBwbGFpbiByZXZlcnQuIE1heWJl IGFzIGEKZm9sbG93IHVwIHBhdGNoIHRvIHRoZSByZXZlcnQ/CgotLSAKUmVnYXJkcywKUHJhdHl1 c2ggWWFkYXYKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpMaW51eCBNVEQgZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56A581F582C for ; Tue, 30 Sep 2025 12:19:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759234773; cv=none; b=rDatlK9MzxSfkrrfS5MNfmWSAMTv/iQVGUmmvCMdq6i++Ad6NG8Pg6pg3oenxKSlVaFAcjtMvXLTavyjt8qDadsqFuCYaOdi7EKmqDTtkIMVE1HZWF+LsJC3VrD2uPcrJnYnr4PtIzs/W0xo0DxwYy37uYtGTVDsL6UsQTdFUek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759234773; c=relaxed/simple; bh=K/02sF+wmK8zVvZYoYSnvHtVxTq3OlWrSzPnKA270yo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=BsgigiTP3UXFhQv3ObQOCKCoaYv8vEf8YUrQZ39eG3THjKOYfKYABSdx3K3/D9kBbjrgwuox1cBo4yOeejnxxnlyuNJlG5wtlvgF4sj7mdkKmE5QrHzGF5/S83KriMyk28TnUFz6EpxZ062+BKIzbZ9+xNcD06DEcs230vsp5Pc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DgfOdVsZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DgfOdVsZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0011C4CEF0; Tue, 30 Sep 2025 12:19:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1759234772; bh=K/02sF+wmK8zVvZYoYSnvHtVxTq3OlWrSzPnKA270yo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=DgfOdVsZlwSmJA7IW7k1lnvV4jlq5FSwwBDuzMpIZGBtUdDVSJgTquIthFlGa5Q8U 98BLtzqFOohEkkPbc8+FNu7gjY9gDH91lZ3yY37wiMqeZfQ1FunDIqwYk9aVycgpCQ dXxcDiggi1UD9be3PF1r8wXAh7sugOD+P308J7IUiCylTcWtP1fagJFIAoAuTBVEiU DjsygnIC5ZyklUWrMKJ+lbJToLW3Vi4CVgR6YK7x5n6zedQdHtCfnR97n3qgBYQMFF 1/JRi/+JyjcMRDQmpoKNYfnAxvKTmdlfBPrraklKJNyL2IozHxYiSgCJw1xVbYn8LX py8sii1AYhYAQ== From: Pratyush Yadav To: Cheng Ming Lin Cc: Michael Walle , Tudor Ambarus , Guenter Roeck , Pratyush Yadav , Cheng Ming Lin , miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, alvinzhou@mxic.com.tw, leoyu@mxic.com.tw, Maarten Zanders Subject: Re: [PATCH v2 1/3] mtd: spi-nor: macronix: Drop the redundant flash info fields In-Reply-To: (Cheng Ming Lin's message of "Tue, 30 Sep 2025 15:36:40 +0800") References: <20250407075400.1113177-1-linchengming884@gmail.com> <20250407075400.1113177-2-linchengming884@gmail.com> Date: Tue, 30 Sep 2025 14:19:29 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, Sep 30 2025, Cheng Ming Lin wrote: > Hi Michael, > > Michael Walle =E6=96=BC 2025=E5=B9=B49=E6=9C=8824=E6= =97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D=888:11=E5=AF=AB=E9=81=93=EF=BC=9A >> >> > The root cause of this problem lies in the failure of parsing the SFDP >> > data for the flash, rather than an issue with the patch itself. I beli= eve >> > we should not revert this patch. >> >> I disagree. There are Macronix flashes with that ID which doesn't >> have SFDP. And this patch is dropping support for them. See also >> [1]. Now I'm not sure it is worth reverting this commit. Nobody, >> except Guenter complained, but only *so far* (and that patch is in >> since 6.16). Any opinions? When I read this I was just hoping no one complains and we end up just dropping support for these flashes that no one seems to use... > > I agree with reverting this patch. When I initially verified it, the > devices I had on hand all supported SFDP, so I did not catch this issue. > After checking again, I confirm that some older flashes without SFDP are > indeed affected. Do you know if these flashes are used in any devices that are actively used and maintained? If so, we should revert. If it is likely they aren't actively used, then maybe we just keep things as they are? Dunno... > > Would it make sense to only change the `.name` field to use a comment, > while keeping the rest as is? That way we can still support flashes that > may not provide SFDP. Sure, that would be a good improvement over a plain revert. Maybe as a follow up patch to the revert? --=20 Regards, Pratyush Yadav