Re: [PATCH 1/2] mtd: spi-nor: spansion: Add support for S28HL256T

[Pratyush Yadav <pratyush@kernel.org>]

On Thu, Dec 19 2024, tkuw584924@gmail.com wrote:

> From: Takahiro Kuwano <Takahiro.Kuwano@infineon.com>
>
> Infineon S28HL256T is 3.0V, 256Mb Flash device with Octal interface.
> It has the same functionalities with S28HS256T(1.8V).
>
> Link: https://www.infineon.com/dgdl/Infineon-S28HS256T_S28HL256T_256Mb_SEMPER_Flash_Octal_interface_1_8V_3-DataSheet-v02_00-EN.pdf?fileId=8ac78c8c8fc2dd9c018fc66787aa0657
> Signed-off-by: Takahiro Kuwano <Takahiro.Kuwano@infineon.com>
> ---
[...]
> diff --git a/drivers/mtd/spi-nor/spansion.c b/drivers/mtd/spi-nor/spansion.c
> index 5a88a6096ca8..f8d8a908c92e 100644
> --- a/drivers/mtd/spi-nor/spansion.c
> +++ b/drivers/mtd/spi-nor/spansion.c
> @@ -957,6 +957,10 @@ static const struct flash_info spansion_nor_parts[] = {
>  		.name = "s25hs02gt",
>  		.mfr_flags = USE_CLPEF,
>  		.fixups = &s25hx_t_fixups
> +	}, {

Even though we don't add name for new flashes in the flash_info, I think
it is still a good idea to have a comment above an entry for which
flash(es) it is for. This would make it easy later to track down more
information about a particular entry.

So unless someone objects, I will add a comment above the flash entry
with the name of the flash in both patches before applying.

> +		.id = SNOR_ID(0x34, 0x5a, 0x19),
> +		.mfr_flags = USE_CLPEF,
> +		.fixups = &s28hx_t_fixups,
>  	}, {
>  		.id = SNOR_ID(0x34, 0x5a, 0x1a),
>  		.name = "s28hl512t",

-- 
Regards,
Pratyush Yadav

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/