From: Pratyush Yadav <pratyush@kernel.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: graf@amazon.com, rppt@kernel.org, changyuanl@google.com,
pasha.tatashin@soleen.com, kexec@lists.infradead.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] liveupdate: kho: remove unneeded semicolon
Date: Mon, 13 Oct 2025 14:21:50 +0200 [thread overview]
Message-ID: <mafs05xcjm1pd.fsf@kernel.org> (raw)
In-Reply-To: <20251013021836.944898-1-jiapeng.chong@linux.alibaba.com> (Jiapeng Chong's message of "Mon, 13 Oct 2025 10:18:36 +0800")
On Mon, Oct 13 2025, Jiapeng Chong wrote:
> No functional modification involved.
>
> ./kernel/liveupdate/kexec_handover.c:1155:2-3: Unneeded semicolon.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=26158
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Looks like it comes from Pasha's series
https://lore.kernel.org/lkml/20251007033100.836886-4-pasha.tatashin@soleen.com/
I think this fix can be folded into the patch since it isn't merged yet.
> ---
> kernel/liveupdate/kexec_handover.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/liveupdate/kexec_handover.c b/kernel/liveupdate/kexec_handover.c
> index 5da21f1510cc..c87d00c40c82 100644
> --- a/kernel/liveupdate/kexec_handover.c
> +++ b/kernel/liveupdate/kexec_handover.c
> @@ -1152,7 +1152,7 @@ static int __kho_finalize(void)
> err |= fdt_begin_node(root, fdt->name);
> err |= fdt_property(root, PROP_SUB_FDT, &phys, sizeof(phys));
> err |= fdt_end_node(root);
> - };
> + }
> mutex_unlock(&kho_out.fdts_lock);
>
> err |= fdt_end_node(root);
--
Regards,
Pratyush Yadav
prev parent reply other threads:[~2025-10-13 12:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 2:18 [PATCH -next] liveupdate: kho: remove unneeded semicolon Jiapeng Chong
2025-10-13 12:21 ` Pratyush Yadav [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mafs05xcjm1pd.fsf@kernel.org \
--to=pratyush@kernel.org \
--cc=abaci@linux.alibaba.com \
--cc=changyuanl@google.com \
--cc=graf@amazon.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.