All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pratyush Yadav <pratyush@kernel.org>
To: Vishwaroop A <va@nvidia.com>
Cc: <tudor.ambarus@linaro.org>,  <pratyush@kernel.org>,
	<mwalle@kernel.org>,  <cmiquel.raynal@bootlin.com>,
	<thierry.reding@gmail.com>,  <richard@nod.at>,  <vigneshr@ti.com>,
	<linux-mtd@lists.infradead.org>,  <linux-kernel@vger.kernel.org>,
	<jonathanh@nvidia.com>,  <kyarlagadda@nvidia.com>,
	<smangipudi@nvidia.com>
Subject: Re: [PATCH 2/3] mtd: spi-nor: Add support for spansion s25fs512s1
Date: Fri, 06 Dec 2024 15:08:51 +0000	[thread overview]
Message-ID: <mafs0frn04zng.fsf@kernel.org> (raw)
In-Reply-To: <20241126185834.1130949-3-va@nvidia.com> (Vishwaroop A.'s message of "Tue, 26 Nov 2024 18:58:33 +0000")

On Tue, Nov 26 2024, Vishwaroop A wrote:

> Add support for the spansion s25fs512s1 SPI NOR flash. This device has
> a 64MB size (SZ_64M), dual/quad read capabilities and apply
> s25fs_s_nor_fixups to handle specific chip behavior.
>
> Erasing, reading and writing this flash device has been validated on
> the Jetson AGX Orin platform using mtd_debug and dd utilities.

Please read https://docs.kernel.org/driver-api/mtd/spi-nor.html for
requirements for adding new flashes. Also, see if you even need a new
entry at all, or the generic SFDP-based driver works for you already. If
not, explain in your patch why.

Same applies to patch 3/3.

-- 
Regards,
Pratyush Yadav

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Pratyush Yadav <pratyush@kernel.org>
To: Vishwaroop A <va@nvidia.com>
Cc: <tudor.ambarus@linaro.org>,  <pratyush@kernel.org>,
	<mwalle@kernel.org>,  <cmiquel.raynal@bootlin.com>,
	<thierry.reding@gmail.com>,  <richard@nod.at>,  <vigneshr@ti.com>,
	<linux-mtd@lists.infradead.org>,  <linux-kernel@vger.kernel.org>,
	<jonathanh@nvidia.com>,  <kyarlagadda@nvidia.com>,
	<smangipudi@nvidia.com>
Subject: Re: [PATCH 2/3] mtd: spi-nor: Add support for spansion s25fs512s1
Date: Fri, 06 Dec 2024 15:08:51 +0000	[thread overview]
Message-ID: <mafs0frn04zng.fsf@kernel.org> (raw)
In-Reply-To: <20241126185834.1130949-3-va@nvidia.com> (Vishwaroop A.'s message of "Tue, 26 Nov 2024 18:58:33 +0000")

On Tue, Nov 26 2024, Vishwaroop A wrote:

> Add support for the spansion s25fs512s1 SPI NOR flash. This device has
> a 64MB size (SZ_64M), dual/quad read capabilities and apply
> s25fs_s_nor_fixups to handle specific chip behavior.
>
> Erasing, reading and writing this flash device has been validated on
> the Jetson AGX Orin platform using mtd_debug and dd utilities.

Please read https://docs.kernel.org/driver-api/mtd/spi-nor.html for
requirements for adding new flashes. Also, see if you even need a new
entry at all, or the generic SFDP-based driver works for you already. If
not, explain in your patch why.

Same applies to patch 3/3.

-- 
Regards,
Pratyush Yadav

  reply	other threads:[~2024-12-06 15:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-26 18:58 [PATCH 0/3] Add support for S25FS512S1, and MX25U51279G Vishwaroop A
2024-11-26 18:58 ` Vishwaroop A
2024-11-26 18:58 ` [PATCH 1/3] mtd: spi-nor: Add post-get-map-id fixup for S25FS512S/S1 Vishwaroop A
2024-11-26 18:58   ` Vishwaroop A
2024-12-06 15:05   ` Pratyush Yadav
2024-12-06 15:05     ` Pratyush Yadav
2024-11-26 18:58 ` [PATCH 2/3] mtd: spi-nor: Add support for spansion s25fs512s1 Vishwaroop A
2024-11-26 18:58   ` Vishwaroop A
2024-12-06 15:08   ` Pratyush Yadav [this message]
2024-12-06 15:08     ` Pratyush Yadav
2024-11-26 18:58 ` [PATCH 3/3] mtd: spi-nor: Add support for mx25u51279g Vishwaroop A
2024-11-26 18:58   ` Vishwaroop A

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mafs0frn04zng.fsf@kernel.org \
    --to=pratyush@kernel.org \
    --cc=cmiquel.raynal@bootlin.com \
    --cc=jonathanh@nvidia.com \
    --cc=kyarlagadda@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mwalle@kernel.org \
    --cc=richard@nod.at \
    --cc=smangipudi@nvidia.com \
    --cc=thierry.reding@gmail.com \
    --cc=tudor.ambarus@linaro.org \
    --cc=va@nvidia.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.