From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59DCEC71144 for ; Wed, 11 Jun 2025 18:00:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pjI2zrDixSfbKjy2J3M1Zn3AgAixxH2Pl5gpFoFjlag=; b=4bnn3NKcdBwajIQMJQ9Snpv67R gcDJqzC+J05xYmuQQq7joWATxVS1WHN4r+GOKOuPN+qD/+RvdkINiBfKJHY7fYMFCb0rJi5REeOl9 eGH1EILa5FDcWXGmdQ1NEAG3//pqZM/Qeq/hCimxTe3K73zxXxDRd2r+n7T1DMCg5X2CCQ0jdo05d VE29vbn7qs/WUYU0BFWYcGa440uXdbOXTKI+SGlR6aBPIlUXtDzrFJMM7W9dks+kFG66LUiCaIxfA 2XkF90/m2XFVz+hkwWaUgXIqDXitfG1dwaV/2cGHBC0iVA71I5LkhMQp48vy4NUqaqUBWeMK1exeZ NjhlxH7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uPPkW-0000000AnIy-2vJZ; Wed, 11 Jun 2025 18:00:32 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uPM1c-0000000A2Ml-1L7s for kexec@lists.infradead.org; Wed, 11 Jun 2025 14:01:57 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 0B3C843D54; Wed, 11 Jun 2025 14:01:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C5C1C4CEEA; Wed, 11 Jun 2025 14:01:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749650515; bh=BAePymoebK5BBu7o01vZEw+cupxxDzaeyWOs5m+KQ88=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=LkVVIMiPzy53gbOuXhKkB5rkSfCB6l8PYd0O1935ufYN+sE6BR/l5ZtC8aRX+EBfp zYoEEYFmX15KBnpmwgjI8/CgvxJ5laOEhekSnSfUhKDNV7J9Xn2c4KU7ofEKZL4Ndu YHcR347Nr7dzll7S6ZtAA0BO7e0cUyrs5X4LJo5ErgCskyeA9p7Cde+iGGzeInSymH 6xlAff7qBC3TLFz00pINbaQLC9F10uUu4hXfmdh/QVRf8tLYRaGY2zjNcVdcea5p11 yblDWSKZOrThyD8FdUnTWw/KFM/dPoKO+HNMFAQ2M/zf3pf6ofWt5pBlADThokceIP 5ULBXZsx/q3Vw== From: Pratyush Yadav To: Mike Rapoport Cc: Pasha Tatashin , Pratyush Yadav , Alexander Graf , Changyuan Lyu , Andrew Morton , Baoquan He , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Clapinski Subject: Re: [PATCH] kho: initialize tail pages for higher order folios properly In-Reply-To: References: Date: Wed, 11 Jun 2025 16:01:52 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250611_070156_397331_09E4CA40 X-CRM114-Status: GOOD ( 38.13 ) X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kexec" Errors-To: kexec-bounces+kexec=archiver.kernel.org@lists.infradead.org On Wed, Jun 11 2025, Mike Rapoport wrote: > On Wed, Jun 11, 2025 at 09:14:55AM -0400, Pasha Tatashin wrote: >> On Wed, Jun 11, 2025 at 9:06=E2=80=AFAM Pratyush Yadav wrote: >> > >> > On Tue, Jun 10 2025, Pasha Tatashin wrote: >> > >> > >> > > I think it should be the other way around, KHO should depend on >> > >> > > !DEFERRED_STRUCT_PAGE_INIT. >> > >> > >> > >> > Agreed, and this is what I first tried, but that does not work, t= here >> > >> > is some circular dependency breaking the build. If you feel >> > >> > adventurous you can try that :-) >> > >> >> > >> Hmm, weird, worked for me :/ >> > >> > Worked for me as well. >> > >> > > >> > > I am super confused, it did not work for me over weekend, and now it >> > > is working. Even `make menuconfig` would not work. Anyways, I will p= ut >> > > it in the appropriate place. >> > > >> > >> >> > >> > > > We will need to teah KHO to work with deferred struct page in= it. I >> > >> > > > suspect, we could init preserved struct pages and then skip o= ver them >> > >> > > > during deferred init. >> > >> > > >> > >> > > We could, but with that would mean we'll run this before SMP an= d it's not >> > >> > > desirable. Also, init_deferred_page() for a random page requires >> > >> > >> > >> > We already run KHO init before smp_init: >> > >> > start_kernel() -> mm_core_init() -> kho_memory_init() -> >> > >> > kho_restore_folio() -> struct pages must be already initialized h= ere! >> > >> > >> > >> > While deferred struct pages are initialized: >> > >> > start_kernel() -> rest_init() -> kernel_init() -> >> > >> > kernel_init_freeable() -> page_alloc_init_late() -> >> > >> > deferred_init_memmap() >> > >> > >> > >> > If the number of preserved pages that is needed during early boot= is >> > >> > relatively small, that it should not be an issue to pre-initialize >> > >> > struct pages for them before deferred struct pages are initialize= d. We >> > >> > already pre-initialize some "struct pages" that are needed during >> > >> > early boot before the reset are initialized, see deferred_grow_zo= ne() >> > >> >> > >> deferred_grow_zone() takes a chunk in the beginning of uninitialize= d range, >> > >> with kho we are talking about some random pages. If we preinit them= early, >> > >> deferred_init_memmap() will overwrite them. >> > > >> > > Yes, this is why I am saying that we would need to skip the KHO >> > > initialized "struct pages" somehow during deferred initialization. If >> > > we create an ordered by PFN list of early-initialized KHO struct >> > > pages, skipping during deferred initialization could be done >> > > efficiently. >> > >> > Or keep things simple and don't use any KHO struct pages during early >> > init. You can access the page itself, just don't use its struct page. >> > >> > Currently the only user of kho_restore_folio() during init is >> > kho_memory_init(). The FDT is accessed by doing >> > phys_to_virt(kho_in.fdt_phys) anyway, so there is really no need for >> > restoring the folio so early. It can be done later, for example when L= UO >> > does the finish event, to clean up and free the folio. >>=20 >> Good suggestion, however, KHO does not have any sophisticated users >> that we are going to be adding as part of the live update work in the >> future: IR, KVM, early VCPU threads, and so on. So, while today, this >> might work, in the future, I am not sure if we should expect struct >> pages are not accessed until after deferred initialization or simply >> fix it once and for all. > > KHO already accesses stuct page early and uses page->private for order. > Since preserved memory is reserved in memblock, deferred init of struct > pages won't touch those pages, we just need to make sure they are properl= y=20 Not strictly true. Some of them might have been initialized from free_area_init() -> memmap_init() (the ones not eligible for deferred init), which happens before KHO makes its memblock reservations. > initialized at some point. If we don't expect many kho_restore_folio() > before page_alloc_init_late() we can use init_deferred_page() for early > accesses. I tried doing this when looking into this initially, but it doesn't work for some reason. static void kho_restore_page(struct page *page, unsigned int order) { unsigned int i, nr_pages =3D (1 << order); =20=20=20=20 /* Head page gets refcount of 1. */ init_deferred_page(page_to_pfn(page), NUMA_NO_NODE); set_page_count(page, 1); =20=20=20=20 /* For higher order folios, tail pages get a page count of zero. */ for (i =3D 1; i < nr_pages; i++) { init_deferred_page(page_to_pfn(page + i), NUMA_NO_NODE); set_page_count(page + i, 0); } =20=20=20=20 [...] results in: [ 0.644032] page:(____ptrval____) is uninitialized and poisoned [ 0.644679] page dumped because: VM_BUG_ON_PAGE(PagePoisoned(page)) [ 0.645376] ------------[ cut here ]------------ [ 0.645883] kernel BUG at ./include/linux/mm.h:1512! [...] [ 0.647924] RIP: 0010:__pageblock_pfn_to_page+0x166/0x180 [...] [ 0.647924] [ 0.647924] set_zone_contiguous+0x6b/0x90 [ 0.647924] page_alloc_init_late+0x356/0x370 [ 0.647924] kernel_init_freeable+0x12d/0x190 [ 0.647924] ? __pfx_kernel_init+0x10/0x10 [ 0.647924] kernel_init+0x1a/0x130 didn't dig any deeper on why it happens... --=20 Regards, Pratyush Yadav