From: Pratyush Yadav <ptyadav@amazon.de>
To: Hazem Mohamed Abuelfotoh <abuehaze@amazon.com>
Cc: <dhowells@redhat.com>, <keyrings@vger.kernel.org>,
<benh@amazon.com>, Pratyush Yadav <ptyadav@amazon.com>
Subject: Re: [PATCH v2 1/1] Pass "err" argument by address to "_nsError" function
Date: Tue, 18 Feb 2025 13:56:36 +0000 [thread overview]
Message-ID: <mafs0tt8rl5kb.fsf@amazon.de> (raw)
In-Reply-To: <20250218132711.34346-1-abuehaze@amazon.com> (Hazem Mohamed Abuelfotoh's message of "Tue, 18 Feb 2025 13:27:11 +0000")
On Tue, Feb 18 2025, Hazem Mohamed Abuelfotoh wrote:
> Commit 0d71523ab584 (“DNS: Support AFS SRV records and
> cell db config files”) has refactored the "nsError" function
> by moving some of error handling to "_nsError" function
> however we are passing the "err" argument to "_nsError"
> by value not by address which is wrong as that basically
> waste any processing we do in the "_nsError" function
> so correcting that by passing "err" by address.
>
> Reported-by: Pratyush Yadav <ptyadav@amazon.com>
> Signed-off-by: Hazem Mohamed Abuelfotoh <abuehaze@amazon.com>
Acked-by: Pratyush Yadav <ptyadav@amazon.de>
--
Regards,
Pratyush Yadav
prev parent reply other threads:[~2025-02-18 13:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 13:27 [PATCH v2 1/1] Pass "err" argument by address to "_nsError" function Hazem Mohamed Abuelfotoh
2025-02-18 13:56 ` Pratyush Yadav [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mafs0tt8rl5kb.fsf@amazon.de \
--to=ptyadav@amazon.de \
--cc=abuehaze@amazon.com \
--cc=benh@amazon.com \
--cc=dhowells@redhat.com \
--cc=keyrings@vger.kernel.org \
--cc=ptyadav@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.