From: Manfred Spraul <manfred@colorfullife.com>
To: linux-ia64@vger.kernel.org
Subject: [Linux-ia64] do_mmap_fake question
Date: Sun, 09 Jul 2000 08:51:44 +0000 [thread overview]
Message-ID: <marc-linux-ia64-105590678205192@msgid-missing> (raw)
do_mmap_fake seems to be buggy:
You use simple memset/memcpy to initialize user memory.
AFAICS this can oops on SMP: one thread calls do_mmap_fake, and a second
thread calls sys_munmap() for that memory range.
memset/memcpy will fail, and you don't have an exception handler
installed.
Btw, why do you use llseek?
Is there a hidden problem with read(,,,&off)?
- llseek(,,off);
- r = file->f_op->read(file,(char*)addr, len, &file->f_pos);
+ r = file->f_op->read(file,(char*)addr, len, &off);
--
Manfred
next reply other threads:[~2000-07-09 8:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-07-09 8:51 Manfred Spraul [this message]
2000-07-10 17:53 ` [Linux-ia64] do_mmap_fake question Don Dugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-105590678205192@msgid-missing \
--to=manfred@colorfullife.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.