All of lore.kernel.org
 help / color / mirror / Atom feed
From: Don Dugger <n0ano@valinux.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [Linux-ia64] Possible bug in getname32
Date: Fri, 16 Mar 2001 16:39:30 +0000	[thread overview]
Message-ID: <marc-linux-ia64-105590693005285@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-105590693005284@msgid-missing>

Dave-

Thanks for the report.  The simple answer is no, this is not a problem
on IA64.

The more detailed answer is we don't use that code.  If you look up
from `getname32' a little you'll discover that this code is inside
a `#ifdef NOTYET' block and is not compiled into the kernel.  When we
started the IA32 support we used, I believe, `sparc64' code as a
template but ifdef'd out most of the code.  As we discovered system
calls that needed to be translated we pulled the code out of the
ifdef area and made sure it worked properly.  (Because of the way
IA64 passes system call parameters many system calls that would need
to be translated on other architectures don't need to be modified
on IA64 and I didn't want to needlessly translate things that `just
work').  The `getname32' code hasn't been needed yet (and probably 
never will be now that you've pointed out a bug with it :-)

On Fri, Mar 16, 2001 at 10:04:23AM -0600, David Engebretsen wrote:
> Although I do not work on linux-ia64, I believe we found a bug bringing up
> PPC64 that also exists in the IA64 code that someone might want to look
> into.
> 
> In arch/ia64/ia32/sys_ia32.c, the function getname32 allocates storage via
> __get_free_page and then returns it via putname (aka kmem_cache_free).
> This mismatch of storage allocation schemes can cause all kinds of subtle
> problems as we found in PPC64.
> 
> Is this a legitimate bug, or are we missing something here?
> 
> Thanks -
> 
> Dave Engebretsen
> Linux on PowerPC Development, IBM Rochester
> Internal  : ibmusm07(engebret), T/L 8-553-2925
> External : engebret@us.ibm.com, (507) 253-2925
> 
> 
> _______________________________________________
> Linux-IA64 mailing list
> Linux-IA64@linuxia64.org
> http://lists.linuxia64.org/lists/listinfo/linux-ia64

-- 
Don Dugger
"Censeo Toto nos in Kansa esse decisse." - D. Gale
n0ano@valinux.com
Ph: 303/938-9838


  reply	other threads:[~2001-03-16 16:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-03-16 16:04 [Linux-ia64] Possible bug in getname32 David Engebretsen
2001-03-16 16:39 ` Don Dugger [this message]
2001-03-16 17:20 ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=marc-linux-ia64-105590693005285@msgid-missing \
    --to=n0ano@valinux.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.