From: David Mosberger <davidm@hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: [Linux-ia64] Re: [patch] fix unaligned references inside s/w pipelined loops
Date: Thu, 18 Oct 2001 00:56:18 +0000 [thread overview]
Message-ID: <marc-linux-ia64-105590698805366@msgid-missing> (raw)
>>>>> On Tue, 16 Oct 2001 08:54:08 -0700, "Luck, Tony" <tony.luck@intel.com> said:
Tony> If an application takes an unaligned trap on a "rotating"
Tony> register inside a software pipelined loop[1], then the kernel
Tony> will use the wrong register when it fixes the fault. This
Tony> results in corrupted memory or register depending on whether
Tony> the unaligned reference was a store or a load respectively.
Tony> Attached is a patch to fix this (both for the integer case,
Tony> which was the one actually reported to me, and the floating
Tony> point case too). Patch is against 2.4.10.
Looks good to me. Patch applied.
Tony> [1] Don't ask me why someone would go through all the effort
Tony> of writing a s/w pipelined loop, but not check for unaligned
Tony> access, I don't understand it either ... but they did.
Well, I can think of one reason: it could make sense if the data
happens to be aligned properly 99.9% of the time. In any case, this
was definitely a bug. Thanks for fixing it.
--david
reply other threads:[~2001-10-18 0:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-105590698805366@msgid-missing \
--to=davidm@hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.