From: David Mosberger <davidm@hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [Linux-ia64] mmio barrier macro
Date: Sat, 15 Dec 2001 00:22:42 +0000 [thread overview]
Message-ID: <marc-linux-ia64-105590698805699@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-105590698805698@msgid-missing>
This patch looks wrong to me. It shouldn't replace __ia64_mf_a() with
platform_mmiob() because this will force the use of mf.a even on
platforms that don't need it for memory-mapped I/O. Also, how about a
comment explaining exactly what is being ordered with respect to whom
(yes, I know there are many examples in Linux where this hasn't been
done, but I don't think that's a good reason to make the situation
worse).
Thanks,
--david
next prev parent reply other threads:[~2001-12-15 0:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-14 22:54 [Linux-ia64] mmio barrier macro Jesse Barnes
2001-12-15 0:22 ` David Mosberger [this message]
2001-12-15 0:55 ` Jesse Barnes
2001-12-17 19:09 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-105590698805699@msgid-missing \
--to=davidm@hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.