All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kimio Suganuma <k-suganuma@mvj.biglobe.ne.jp>
To: linux-ia64@vger.kernel.org
Subject: [Linux-ia64] CPU hotplug boot change for IA64
Date: Fri, 02 Aug 2002 21:22:40 +0000	[thread overview]
Message-ID: <marc-linux-ia64-105590701905891@msgid-missing> (raw)

[-- Attachment #1: Type: text/plain, Size: 1092 bytes --]

Hi David, Rusty,

I attached a CPU hotplug boot change patch for IA-64
against 2.5.29 + David's IA64 patch. Please include this in
the next release.

I've just tested it on a 2way Bigsur but it should work on
the other systems.

In this patch, I added initial value of cpu_online_map as following,

 /* Bitmask of currently online CPUs */
-volatile unsigned long cpu_online_map;
+volatile unsigned long cpu_online_map = 1;
 unsigned long phys_cpu_present_map;

Bit for CPU#0 on cpu_online_map was set at smp_boot_cpus() before.
But on the 2.5.29, place of calling smp_boot_cpus() is changed to
later timing and this seems to make a chance that smp_call_function()
is called before setting cpu_online_map, (I guess.)
In that case, smp_call_function won't return because num_online_cpus()
returns 0 and the system will hang.

I have an experience of this problem only on a large system
like Tiger, but it may occur on another system.

Rusty, I guess this modification should be needed for i386, too.

I'd appreciate any comment.

Thanks,
Kimi

-- 
Kimio Suganuma <k-suganuma@mvj.biglobe.ne.jp>

[-- Attachment #2: hotplug-boot-change-ia64.patch.gz --]
[-- Type: application/octet-stream, Size: 2670 bytes --]

                 reply	other threads:[~2002-08-02 21:22 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=marc-linux-ia64-105590701905891@msgid-missing \
    --to=k-suganuma@mvj.biglobe.ne.jp \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.